Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Rodrigue Koffi <[email protected]>
  • Loading branch information
ruchimo and bonclay7 authored Jan 18, 2024
1 parent ce8950e commit 32ecaf3
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 7 deletions.
8 changes: 4 additions & 4 deletions docs/container-insights/eks.md
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,8 @@ Simply run this command to deploy the example
terraform apply
```

## Enabling Application Signals for your services
CloudWatch Application Signals is currenlty supported for **Java** applications running on your Amazon EKS cluster.
## Enabling Application Signals (preview) for your services
CloudWatch Application Signals (preview) is currenlty supported for **Java** applications running on your Amazon EKS cluster.

Next, you have to update your Application to `Configure application metrics and trace sampling`. For this, you must add an annotation to a manifest YAML in your cluster. Adding this annotation auto-instruments the application to send metrics, traces, and logs to Application Signals. You have two options for the annotation:

Expand All @@ -62,12 +62,12 @@ Next, you have to update your Application to `Configure application metrics and
## Visualization of Container Insights data
After the terraform apply is successful, open your Amazon CloudWatch console in the same region as your EKS cluster, then from the left hand side choose `Insights -> Container Insights`, there choose the `EKS` from the drop down and you will see the metrics shown on the dashboard:
After `terraform apply` is successful, open your Amazon CloudWatch console in the same region as your EKS cluster, then from the left hand side choose `Insights -> Container Insights`, there choose the `EKS` from the drop down and you will see the metrics shown on the dashboard:
<img width="1345" alt="image" src="https://github.com/ruchimo/terraform-aws-observability-accelerator/assets/106240341/31686b29-8ec2-46ff-a266-ebfa1de9768a">
## Visualization of Application Signal data
## Visualization of CloudWatch Application Signals (preview) data
After enabling your Application to pass metrics and traces by following [the steps provided above](#enabling-application-signals-for-your-services), open your Amazon CloudWatch console in the same region as your EKS cluster, then from the left hand side choose `Application Signals -> Services` and you will see the metrics shown on the sample dashboard below:
Expand Down
5 changes: 2 additions & 3 deletions examples/eks-container-insights/README.md
Original file line number Diff line number Diff line change
@@ -1,9 +1,8 @@
# Enable Container Insights for EKS cluster

This example deploys Amazon CloudWatch Application Signal and Container Insights as an EKS add-on on your EKS cluster which enables Container Insights metrics and Application Signals on CloudWatch.
This example enables enhanced CloudWatch Container Insights for EKS and CloudWatch Application Signals (preview) through our CloudWatch EKS add-ons, providing comprehensive metrics, logs, and insights for cluster and application monitoring.

Step-by-step instructions available on our [docs site](https://aws-observability.github.io/terraform-aws-observability-accelerator/)
under **Amazon CloudWatch Container Insights**
Step-by-step instructions available on our [docs site](https://aws-observability.github.io/terraform-aws-observability-accelerator/container-insights/eks/)

<!-- BEGINNING OF PRE-COMMIT-TERRAFORM DOCS HOOK -->
## Requirements
Expand Down

0 comments on commit 32ecaf3

Please sign in to comment.