populate aws.trace.flag.sampled attribute only if unsampled

aws-observability · Nov 12, 2024 · 43af1e5 · 43af1e5
1 parent 3557f6a
commit 43af1e5
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 5 deletions.
diff --git a/...java/software/amazon/opentelemetry/javaagent/providers/AwsUnsampledOnlySpanProcessor.java b/...java/software/amazon/opentelemetry/javaagent/providers/AwsUnsampledOnlySpanProcessor.java
@@ -40,9 +40,7 @@ public static AwsUnsampledOnlySpanProcessorBuilder builder() {
 
   @Override
   public void onStart(Context parentContext, ReadWriteSpan span) {
-    if (span.getSpanContext().isSampled()) {
-      span.setAttribute(AwsAttributeKeys.AWS_TRACE_FLAG_SAMPLED, true);
-    } else {
+    if (!span.getSpanContext().isSampled()) {
       span.setAttribute(AwsAttributeKeys.AWS_TRACE_FLAG_SAMPLED, false);
     }
     delegate.onStart(parentContext, span);

diff --git a/.../software/amazon/opentelemetry/javaagent/providers/AwsUnsampledOnlySpanProcessorTest.java b/.../software/amazon/opentelemetry/javaagent/providers/AwsUnsampledOnlySpanProcessorTest.java
@@ -88,8 +88,8 @@ public void testStartAddsAttributeToSampledSpan() {
     AwsUnsampledOnlySpanProcessor processor = AwsUnsampledOnlySpanProcessor.builder().build();
     processor.onStart(parentContextMock, spanMock);
 
-    // verify setAttribute was called with the correct arguments
-    verify(spanMock, times(1)).setAttribute(AwsAttributeKeys.AWS_TRACE_FLAG_SAMPLED, true);
+    // verify setAttribute was never called
+    verify(spanMock, never()).setAttribute(any(), anyBoolean());
   }
 
   @Test