-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: recover or replace launch dir link if missing #1679
Conversation
d111bc3
to
8f923e6
Compare
691ba14
Binary incompatibility detected for commit 691ba14. com.aws.greengrass.lifecyclemanager.KernelAlternatives is binary incompatible and is source incompatible because of METHOD_LESS_ACCESSIBLE Produced by binaryCompatability.py |
Unit Tests Coverage Report
Minimum allowed coverage is Generated by 🐒 cobertura-action against 691ba14 |
Integration Tests Coverage Report
Minimum allowed coverage is Generated by 🐒 cobertura-action against 691ba14 |
Issue #, if available:
Description of changes:
Re create (if not present) and re link the current launch directory symbolic link with the Nucleus package which is currently being executed. This will only be executed if the current launch directory symbolic link does not exist.
If the current Nucleus package in execution does not have a loader file in its un-archived path, un-archive the the current Nucleus package artifact to re-populate the loader paths.
Region Issue Fix
As Device Configuration is getting initialized earlier than expected, Nucleus is picking up the region from env at each restart and committing that into its config with the latest timestamp. Correct region which is actually picked later on from
config.tlog
is discarded as its timestamp being older than current region topic's timestamp. The fix is to prefer latest region committed inconfig.tlog
if present.Why is this change necessary:
This change is necessary to mitigate deployment failures due to Launch Dir Corrupted.
How was this change tested:
Any additional information or context required to review the change:
Documentation Checklist:
Compatibility Checklist:
any deprecated method or type.
Refer to Compatibility Guidelines for more information.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.