Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add utilities to convert GPS trace file formats into SnapToRoads request #44
base: main
Are you sure you want to change the base?
Add utilities to convert GPS trace file formats into SnapToRoads request #44
Changes from 2 commits
29fd3cb
7b66be0
6d2000a
0d0bf5f
c2dd6d3
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(We could also support CSVs without header rows by accepting an array with column names as
columnNames
or similar.)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do our APIs require the
FP:
prefix? The API reference doesn't say anything about it, but that might be wrong.Check warning on line 5 in src/from-flexible-polyline/tracepoints-converter.ts
GitHub Actions / build
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Be explicit about the full order in case
speed_kmh
is absent but the other 2 are present for whatever reason.Check warning on line 89 in src/from-geojson/tracepoints-converter.ts
GitHub Actions / build