Flatten simple geometry collections #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
The README should also get updated to describe the API change. Also, if the intent is to release a new version with this change, the version number should get bumped too. I would suggest "1.2.0" since I don't think it's exactly a breaking change if people are just using it as GeoJSON output, but it's more than a bugfix.
|
I'll push a change with an update to the README. +1 to 1.2.0 (I agree with your reasoning). |
mojodna
changed the title
mojodna
force-pushed
the
flatten-simple-geometry-collections
branch
2 times, most recently
from
b76a212 to
d3aaa74
Compare
cgalvan
reviewed
Nov 13, 2024
tjmichaels
previously approved these changes
Nov 14, 2024
mojodna
force-pushed
the
flatten-simple-geometry-collections
branch
from
d3aaa74 to
db5c817
Compare
mbalfour-amzn
approved these changes
Nov 14, 2024
cgalvan
approved these changes
Nov 14, 2024
GeoJSONLint complains about these types of features: > GeometryCollection with a single geometry should be avoided in favor > of single part or a single object of multi-part type This simultaneously expands (`GeometryCollection | Polygon`) and narrows (`GeometryCollection<Polygon | LineString>`) the type of GeoJSON features created from isolines.
cgalvan
force-pushed
the
flatten-simple-geometry-collections
branch
from
db5c817 to
a855bb0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
GeoJSONLint complains about these types of features:
This PR simplifies features containing GeometryCollections with single geometries by removing the intermediate GeometryCollection.
This simultaneously expands (
GeometryCollection | Polygon) and narrows (GeometryCollection<Polygon | LineString>) the type of GeoJSON features created from isolines. We should consider the versioning implications of this.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.