-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added authentication with custom credential provider and removed authentication with API key #9
Merged
Merged
Changes from 18 commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
4ec944f
feat: removed API key usage
shah272728 1d939b5
Merge pull request #15 from makeen-project/ALMS-175
olegfilimonov 298041c
feat: Add support for custom credential providers in Auth SDK
shah272728 98a2edb
feat: code optimize
shah272728 a71e17f
feat: Add support for custom credential providers in Auth SDK
shah272728 031ff58
feat: Add support for custom credential providers in Auth SDK
shah272728 8ebb0fd
Merge pull request #16 from makeen-project/ALMS-205
olegfilimonov 9dd9aa4
feat: readme file updated
shah272728 cebf64f
Merge pull request #17 from makeen-project/ALMS-226
olegfilimonov 4477928
feat: github action added for unit test
shah272728 949eac1
feat: code optimize
shah272728 e38fb3f
feat: test result upload
shah272728 2aedf39
feat: test result upload
shah272728 000aa7f
feat: changed to ubuntu-latest
shah272728 f8f6969
feat: code optimize
shah272728 c00a3db
feat: code optimization
shah272728 0941d1c
Merge pull request #18 from makeen-project/ALMS-211
olegfilimonov 8036766
Merge pull request #19 from makeen-project/pr_comment
olegfilimonov 1bbca8a
feat: PR comment addressed
shah272728 7bdacce
Merge pull request #20 from makeen-project/pr_comment
olegfilimonov File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,29 @@ | ||
name: Run Unit Tests for Android | ||
on: | ||
workflow_dispatch: | ||
pull_request: | ||
branches: [ main ] | ||
jobs: | ||
test-android: | ||
name: Test Android | ||
runs-on: ubuntu-latest | ||
steps: | ||
- uses: actions/checkout@v3 | ||
|
||
- name: Setup Java | ||
uses: actions/setup-java@v3 | ||
with: | ||
distribution: 'zulu' | ||
java-version: '17' | ||
|
||
- name: Run Unit Tests | ||
run: | | ||
./gradlew testDebugUnitTest | ||
|
||
- name: Upload test results | ||
uses: actions/upload-artifact@v2 | ||
if: always() | ||
with: | ||
name: test-results | ||
path: library/build/reports/tests/testDebugUnitTest/ | ||
retention-days: 1 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
59 changes: 0 additions & 59 deletions
59
library/src/main/java/software/amazon/location/auth/ApiKeyCredentialsProvider.kt
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The second argument in the
authenticateWithCredentialsProvider
is not as string, it is aCredentialsProvider
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resolved