Backed out API implementation changes #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A lot of the internals of the implementation are relied on by the Tracking SDK, so they can't be removed at this time.
tjmichaels
approved these changes
Oct 31, 2024
cgalvan
approved these changes
Oct 31, 2024
This will make it easier to deprecate the parameter in the future.
cgalvan
approved these changes
Oct 31, 2024
tjmichaels
approved these changes
Oct 31, 2024
cgalvan
approved these changes
Oct 31, 2024
tjmichaels
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
The previous commit introduced a series of internal implementation changes to simplify the overall implementation. However, these methods were still being used by the Tracking SDK as well, so they can't be removed at this time.
This PR preserves the new API design, though with the reintroduction of the Context parameter, since it's required for internally caching the credentials.
In the future, the implementation will hopefully be able to be simplified again. It just needs to be done in conjunction with a refactor of the Tracking SDK.
This also steps down the core-ktx version as it was going to cause downstream libraries to need to change a number of library versions as well.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.