Updated CloudFormation templates #241
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated CloudFormation templates
mbalfour-amzn
approved these changes
Aug 21, 2024
Comment on lines
+701
to
+706
| const splitEndpointAddress = data.endpointAddress.split("."); | ||
| const endpointAddress = !splitEndpointAddress[0].endsWith("-ats") | ||
| ? `${splitEndpointAddress[0]}-ats.${splitEndpointAddress | ||
| .splice(1) | ||
| .join(".")}` | ||
| : data.endpointAddress; |
There was a problem hiding this comment.
Actually, looking at this further, I don't understand the logic here. From the IoT docs, it seems like the "-ats" is distinguishing between Verisign-signed and ATS-signed endpoints: https://docs.aws.amazon.com/iot/latest/apireference/API_DescribeEndpoint.html . If the goal is to always have ats-signed endpoints, shouldn't this be passing in endpointType = iot:Data-ATS? I'm not sure it's guaranteed that you can take a Verisign-signed endpoint and just tack "-ats" at the end to get an ATS-signed endpoint.
There was a problem hiding this comment.
@mbalfour-amzn closing this, raised another PR that is updated with main, and that PR resolves your above comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the default and main CloudFormation template, handling websocket URL output value.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.