Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated dependencies to resolve security issue #227

Closed

Conversation

cgalvan
Copy link
Contributor

@cgalvan cgalvan commented Jul 31, 2024

Description

Updated dependencies to resolve security issue with fast-xml-parser: https://github.com/aws-geospatial/amazon-location-features-demo-web/security

Testing

Built/ran ci-test.

security-tests/package.json Outdated Show resolved Hide resolved
@its-aazizi
Copy link
Collaborator

@cgalvan PRs raised from forked repos against main do not have access to github secrets for security reasons, I believe that is the reason all tests are failing. The way we work around this is mentioned below;

  1. PR for forked/feature_branch against aws-geospatial/feature_branch
  2. Once merged, raise another PR aws-geospatual/feature_branch against main

@cgalvan
Copy link
Contributor Author

cgalvan commented Aug 6, 2024

@cgalvan PRs raised from forked repos against main do not have access to github secrets for security reasons, I believe that is the reason all tests are failing. The way we work around this is mentioned below;

  1. PR for forked/feature_branch against aws-geospatial/feature_branch
  2. Once merged, raise another PR aws-geospatual/feature_branch against main

Oh that makes sense :) I can do that, thanks!

@its-aazizi
Copy link
Collaborator

@cgalvan We have been locking down the version for deps, I see that "^" has been introduced for the updated deps.

@cgalvan
Copy link
Contributor Author

cgalvan commented Aug 7, 2024

@cgalvan We have been locking down the version for deps, I see that "^" has been introduced for the updated deps.

Will dependabot still give us minor version updates if we specify an explicit version instead of allowing compatible versions?

Best practice is to use ^ and commit the package-lock.json, which ensures developers are working with the same dependencies while also allowing dependencies to be updated within compatible range by dependabot.

@its-aazizi
Copy link
Collaborator

its-aazizi commented Aug 8, 2024

@cgalvan dependabot will still raise PRs regardless of the "^". We can definitely have "^" before the version for minor updates. I ended up removing the "^" after Vi's and Devesh's feedback.

@mbalfour-amzn
Copy link
Contributor

No longer needed, dependabot PR resolved the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants