ALS-1889 Map language support added and political view updated #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ALS-1885
…he dropdown ALS-1903
…he dropdown ALS-1903
ALS-1889
…on screen bug fix ALS-1905
… strings ALS-1889
ALS-1889
… and hybrid and satellite map style
…ulation and map style
| countryName = context.getString(R.string.label_vnm), | ||
| description = context.getString(R.string.description_vnm), | ||
| countryCode = context.getString(R.string.flag_vnm), | ||
| fun setPoliticalListData(context: Context) { |
There was a problem hiding this comment.
This code looks like it's duplicated between ExploreView and MapStyleView, can it be shared between them?
mbalfour-amzn
approved these changes
Dec 18, 2024
cgalvan
approved these changes
Dec 18, 2024
Comment on lines
+46
to
+71
| Thread.sleep(DELAY_2000) | ||
| } | ||
| uiDevice.findObject(By.text(WHILE_USING_THE_APP))?.click() | ||
| uiDevice.findObject(By.text(WHILE_USING_THE_APP_CAPS))?.click() | ||
| uiDevice.findObject(By.text(WHILE_USING_THE_APP_ALLOW))?.click() | ||
| uiDevice.findObject(By.text(ALLOW))?.click() | ||
| Thread.sleep(DELAY_2000) | ||
| enableGPS(ApplicationProvider.getApplicationContext()) | ||
| Thread.sleep(DELAY_2000) | ||
| uiDevice.wait(Until.hasObject(By.desc(AMAZON_MAP_READY)), DELAY_15000) | ||
|
|
||
| Thread.sleep(DELAY_2000) | ||
|
|
||
| goToMapStyles() | ||
|
|
||
| val clMapLanguage = | ||
| onView(withId(R.id.cl_map_language)).check(matches(isDisplayed())) | ||
| clMapLanguage.perform(click()) | ||
|
|
||
| Thread.sleep(DELAY_2000) | ||
|
|
||
| val language = | ||
| waitForView(allOf(withText(TEST_WORD_LANGUAGE_AR), isDisplayed())) | ||
| language?.perform(click()) | ||
|
|
||
| Thread.sleep(DELAY_2000) |
There was a problem hiding this comment.
Are these 2 second sleeps the only way we can verify it is safe to move to the next step, or is there event-based mechanism?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.