-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Perforce networking refactor #410
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henrykie
force-pushed
the
henrykie/perforce/refactor
branch
from
December 12, 2024 23:48
5e4ae18
to
5da657e
Compare
henrykie
force-pushed
the
henrykie/perforce/refactor
branch
2 times, most recently
from
December 18, 2024 06:22
a96d3a1
to
e8921a6
Compare
jorisdon
reviewed
Dec 18, 2024
…external networking configuration
… configuration across services
…reference architecture
henrykie
force-pushed
the
henrykie/perforce/refactor
branch
from
January 2, 2025 19:09
10332f2
to
a12471a
Compare
jorisdon
approved these changes
Jan 3, 2025
GrzesiekO
approved these changes
Jan 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving - all good.
GrzesiekO
approved these changes
Jan 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resolved conversations - approving.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
Closes #402
Closes #408
Summary
Networking updates to Perforce modules. Helix Core now supports plaintext configuration. This allows TLS termination to be handled by an NLB in front of the Helix Core server. ALB creation for Helix Swarm and Helix Authentication Service is now optional, allowing shared ALBs created in higher order or root modules to forward requests to target groups output by these modules.
Changes
plaintext
option to Perforce Helix Core module. This disables the ssl: prefix on the Helix Core server directly, and does not generate self-signed certs. We recommend using an NLB in front of the Helix Core server for TLS termination when using this option.User experience
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created might not be successful.