Fix(Simple Build Pipeline): Removes race condition between helix core and helix authentication service #338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorisdon
previously approved these changes
Oct 2, 2024
gabebatista
force-pushed
the
gabeaws/perforce/sbp-race-condition
branch
from
e98e4ec to
0292806
Compare
henrykie
approved these changes
Oct 3, 2024
henrykie
previously approved these changes
Oct 3, 2024
henrykie
previously approved these changes
Oct 4, 2024
gabebatista
force-pushed
the
gabeaws/perforce/sbp-race-condition
branch
2 times, most recently
from
2932d34 to
64d9666
Compare
kylesomers
previously approved these changes
Oct 4, 2024
gabebatista
force-pushed
the
gabeaws/perforce/sbp-race-condition
branch
from
64d9666 to
4720bcc
Compare
gabebatista
force-pushed
the
gabeaws/perforce/sbp-race-condition
branch
from
4720bcc to
ffb3c5a
Compare
…lix authentication service to remove race condition
gabebatista
force-pushed
the
gabeaws/perforce/sbp-race-condition
branch
from
ffb3c5a to
ae40f6b
Compare
|
@gabebatista What is up with the issue number? |
henrykie
approved these changes
Oct 4, 2024
jcwolfaws
pushed a commit
to jcwolfaws/cloud-game-development-toolkit
that referenced
this pull request
Dec 10, 2024
… and helix authentication service (aws-games#338)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: #297
Summary
Adds dependency between Helix Core and Helix Authentication Service in the
simple-build-pipelinesample. This ensures that Helix Authentication Service is always deployed prior to Helix Core coming online, which removes an existing race condition where deployment fails is Helix Core comes online and can't find Helix Authentication Service.Removes 2 binary files accidentally added to the
modules/perforce/helix-coredirectory.Changes
Adds dependency between Helix Core and Helix Authentication Service in the
simple-build-pipelinesample. This ensures that Helix Authentication Service is always deployed prior to Helix Core coming online, which removes an existing race condition where deployment fails is Helix Core comes online and can't find Helix Authentication Service.Removes 2 binary files accidentally added to the
modules/perforce/helix-coredirectory.User experience
Removes race condition from
simple-build-pipelinedeployment, improving user experience.Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
NoAcknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created might not be successful.