Henrykie/helix swarm #306
Merged
Henrykie/helix swarm #306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
henrykie
force-pushed
the
henrykie/helix-swarm
branch
from
db6c82a to
3529f3f
Compare
gabebatista
previously approved these changes
Sep 27, 2024
kylesomers
requested changes
Sep 27, 2024
henrykie
force-pushed
the
henrykie/helix-swarm
branch
from
b257f36 to
d724fa1
Compare
|
@jorisdon @gabebatista @kylesomers I've made changes to the actual commit history on this branch to match Joris's git strategy as discussed. Individual commits can be reviewed as discrete pieces (swarm updates, core updates, etc...). This makes reviews easier. It also allows us to rebase the feature branch onto main and have each of these commits show up in changelog. |
henrykie
force-pushed
the
henrykie/helix-swarm
branch
3 times, most recently
from
f6425ef to
28710a7
Compare
kylesomers
previously approved these changes
Sep 30, 2024
Introduces Elasticache for Redis OSS in place of the redis sidecar container. Removes unsupported EFS variables and IAM permissions. Adds configuration sidecar for enabling SSO login on Helix Swarm.
…ervice deployments
…s are not provided
…ix Authentication Service
… sample Helix Swarm module
henrykie
force-pushed
the
henrykie/helix-swarm
branch
from
28710a7 to
87e1578
Compare
jcwolfaws
pushed a commit
to jcwolfaws/cloud-game-development-toolkit
that referenced
this pull request
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
closes #41
closes #294
Summary
General improvements to the Perforce Helix Swarm module, and Perforce Helix Swarm example configurations.
Changes
= Replace Redis sidecar container with Elasticache.
= Adds SSO enable flag to Helix Swarm module.
User experience
enable_ssoto configure Swarm to use the SSO login page.existing_redis_connectionvariable.Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
Yes. This does replace the existing Redis sidecar container in the Helix Swarm module with a dedicated Elasticache cluster.
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created might not be successful.