Ochmang/terraformfix al2023 #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds support for running the application on Amazon Linux 2023. The necessary configuration changes have been made to the deployment scripts and the application has been tested to ensure compatibility with the new platform. Especially in terraform so it properly refernces new AMI.
Updated the p4_configure.sh script to include a new function that appends the newly mounted EBS volumes or FSx mount points to the /etc/fstab file. This ensures the mounts persist across reboots. Also made some minor updates to the Terraform module configurations for the Helix Core resources to align with the script changes.
kylesomers
reviewed
Jul 26, 2024
| @@ -35,7 +35,7 @@ resource "aws_instance" "helix_core_instance" { | |||
|
|
|||
| user_data = <<-EOT | |||
| #!/bin/bash | |||
| /home/rocky/p4_configure.sh /dev/nvme1n1 /dev/nvme2n1 /dev/nvme3n1 \ | |||
| /home/ec2-user/gpic_scripts/p4_configure.sh /dev/sdf /dev/sdg /dev/sdh \ | |||
There was a problem hiding this comment.
I would rename directory "cloud-game-development-toolkit"
kylesomers
previously requested changes
Jul 26, 2024
This commit adds support for running the application on Amazon Linux 2023. The necessary configuration changes have been made to the deployment scripts and the application has been tested to ensure compatibility with the new platform. Especially in terraform so it properly refernces new AMI.
Updated the p4_configure.sh script to include a new function that appends the newly mounted EBS volumes or FSx mount points to the /etc/fstab file. This ensures the mounts persist across reboots. Also made some minor updates to the Terraform module configurations for the Helix Core resources to align with the script changes.
henrykie
force-pushed
the
ochmang/terraformfixAL2023
branch
from
673c944 to
2e877da
Compare
…ames/cloud-game-development-toolkit into ochmang/terraformfixAL2023
henrykie
approved these changes
Jul 29, 2024
jcwolfaws
pushed a commit
to jcwolfaws/cloud-game-development-toolkit
that referenced
this pull request
Dec 10, 2024
Co-authored-by: Henry <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes
This pull request updates the p4_configure.sh script and the Terraform module configurations for the Helix Core resources. The key changes include:
Added a new function to the p4_configure.sh script that appends the newly mounted EBS volumes or FSx mount points to the /etc/fstab file. This ensures the mounts persist across reboots.
Updated the Terraform module configurations to align with the changes made to the p4_configure.sh script.
User experience
Before this change, the mounts created by the p4_configure.sh script would not persist across reboots, requiring manual intervention to remount the volumes. After this change, the mounts will be automatically remounted on system restart, providing a more seamless user experience.
Checklist
[x] I have performed a self-review of this change
[x] Changes have been tested
[x] Changes are documented
Is this a breaking change?
No, this change is not a breaking change. It enhances the existing functionality without modifying the core behavior of the system.Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.