Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow Jenkins build agents to discover FSx volumes/snapshots and make outbound Internet connections #147

Merged
merged 2 commits into from
Jul 19, 2024

Conversation

jorisdon
Copy link
Contributor

Issue number: N/A

Summary

Changes

  • Jenkins build agents EC2 instance profile can now invoke FSx's DescribeVolumes and DescribeSnapshots APIs without supplying a snapshot/volume filter. These APIs require IAM permissions on <...>:volume/*/* and <...>:snapshot/*.* in order to discover snapshots and volumes accordingly. The ability to discover snapshots and volumes through these APIs is needed by the FSx automounter scripts. Users that bake the FSx mount commands into their AMIs can remove or downscope these permissions.
  • Jenkins build agents now have outbound internet access configured in their security groups, which is needed to pull repositories and install dependencies from the Internet at build-time.

User experience

No changes in user experience

Checklist

If your change doesn't seem to apply, please leave them unchecked.

  • I have performed a self-review of this change
  • Changes have been tested
  • Changes are documented

(note: documentation changes not needed due to documentation automation / dependent on other PRs)

Is this a breaking change? No

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created might not be successful.

@jorisdon jorisdon requested a review from a team as a code owner July 18, 2024 13:03
Copy link
Contributor

@henrykie henrykie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix.

@jorisdon jorisdon merged commit 4e3d512 into main Jul 19, 2024
4 of 6 checks passed
@jorisdon jorisdon deleted the jorisdon/fix-jenkins-simple-build-pipeline branch July 19, 2024 08:00
jcwolfaws pushed a commit to jcwolfaws/cloud-game-development-toolkit that referenced this pull request Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants