-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gabeaws/jenkins readme updates #145
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple minor things. Main concern is that a lot of the details around setup probably belong in sample documentation, not module documentation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor things, but it looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see feedback on jenkins password handling. let's hold off on merging this until that fix is completed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Modify this to write to Secrets Manager, not log output. Cut a PR to fix that in the module
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe that password only works for the first time configuration then gets replaced with the user you create in the setup process. To change this behavior we would need to edit the jenkins docker image we use to setup the service, meaning we would need to distribute our own image to be used. @henrykie please correct me if I'm wrong about this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also @kylesomers we do not have the capacity to update the way that Jenkins writes to logs. This module uses the default image available on Dockerhub without any extensions or adjustments to the entrypoint. For initial release we aren't modifying this, so we cannot adjust the way that Jenkins is initially configured.
@gabebatista Hey dude - trying to get the commit history on this branch cleaned up. The rebase got messed up. Your PR shouldn't include all these file changes we made to Jenkins pipelines, etc. |
c1c0809
to
a821b23
Compare
Still pretty messy, but definitely cleaned up a good amount. |
1738584
to
3c0820a
Compare
…SSH keys to AWS Secrets Manager
… to project for future use
…g and using the AWS Secrets Manager Credentials Provider Plugin
… does not support SSH keys with passphrases.
3c0820a
to
1f89ef0
Compare
Co-authored-by: Henry Kiem <[email protected]>
Issue number:
Summary
Version one of Jenkins module documentation
Changes
Added Jenkins module documentation.
Sections added:
User experience
The changes help to improve the users experience by walking them through the setup and configuration of the Jenkins module.
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
NoAcknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created might not be successful.