-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update passwordless docs with Android examples #8139
Conversation
|
||
```ts title="amplify/backend.ts" | ||
import { defineBackend } from '@aws-amplify/backend' | ||
import { auth } from './auth/resource' | ||
import { data } from './data/resource' | ||
|
||
const backend = defineBackend({ | ||
auth, | ||
data, | ||
}); | ||
|
||
// highlight-start | ||
backend.auth.resources.cfnResources.cfnUserPoolClient.explicitAuthFlows = [ | ||
"ALLOW_USER_PASSWORD_AUTH", | ||
"ALLOW_USER_SRP_AUTH", | ||
"ALLOW_USER_AUTH", | ||
"ALLOW_REFRESH_TOKEN_AUTH" | ||
]; | ||
// highlight-end | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would suggest that we navigate them to other page which has this example already defined on how to setup the backend for passwordless.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't speak for Matt who wrote this part, but the section you called out is under the USER_PASSWORD_AUTH
section of the documentation. In fact this section is what exists on the Swift side today. �
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 to moving this into the overrides section with a callout in this section pointing to the other doc. We have a callout elsewhere with a link to the github issue tracking the feature request that can be reused
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@josefaidt Where is the overrides section? And I'm confused why we would want to add the the Github for USER_AUTH
when this sectino is for USER_PASSWORD_AUTH
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's the "modify existing resources..." page, and the callout is here https://github.com/aws-amplify/docs/blob/main/src/pages/%5Bplatform%5D/build-a-backend/auth/concepts/passwordless/index.mdx?plain=1#L39-L43
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed this section entirely as per a conversation with @josefaidt
src/pages/[platform]/build-a-backend/auth/connect-your-frontend/multi-step-sign-in/index.mdx
Outdated
Show resolved
Hide resolved
src/pages/[platform]/build-a-backend/auth/connect-your-frontend/multi-step-sign-in/index.mdx
Outdated
Show resolved
Hide resolved
src/pages/[platform]/build-a-backend/auth/connect-your-frontend/multi-step-sign-in/index.mdx
Outdated
Show resolved
Hide resolved
src/pages/[platform]/build-a-backend/auth/connect-your-frontend/multi-step-sign-in/index.mdx
Outdated
Show resolved
Hide resolved
…d/multi-step-sign-in/index.mdx Co-authored-by: josef <[email protected]>
…d/multi-step-sign-in/index.mdx Co-authored-by: josef <[email protected]>
src/pages/[platform]/build-a-backend/auth/connect-your-frontend/sign-up/index.mdx
Outdated
Show resolved
Hide resolved
src/pages/[platform]/build-a-backend/auth/connect-your-frontend/sign-up/index.mdx
Outdated
Show resolved
Hide resolved
...latform]/build-a-backend/auth/connect-your-frontend/switching-authentication-flows/index.mdx
Outdated
Show resolved
Hide resolved
...latform]/build-a-backend/auth/connect-your-frontend/switching-authentication-flows/index.mdx
Show resolved
Hide resolved
Co-authored-by: josef <[email protected]>
src/pages/[platform]/build-a-backend/auth/connect-your-frontend/sign-in/index.mdx
Outdated
Show resolved
Hide resolved
…d/sign-in/index.mdx Co-authored-by: James Jarvis <[email protected]>
Description of changes:
This adds all of the Android documentation for Passwordless. The tip of main has already been merged into this branch so everything should be up-to-date as of this posting.
Related GitHub issue #, if available:
Instructions
If this PR should not be merged upon approval for any reason, please submit as a DRAFT
Which product(s) are affected by this PR (if applicable)?
Which platform(s) are affected by this PR (if applicable)?
Please add the product(s)/platform(s) affected to the PR title
Checks
Does this PR conform to the styleguide?
Does this PR include filetypes other than markdown or images? Please add or update unit tests accordingly.
Are any files being deleted with this PR? If so, have the needed redirects been created?
Are all links in MDX files using the MDX link syntax rather than HTML link syntax?
ref: MDX:
[link](https://docs.amplify.aws/)
HTML:
<a href="https://docs.amplify.aws/">link</a>
When this PR is ready to merge, please check the box below
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.