Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update passwordless docs with Android examples #8139

Merged
merged 20 commits into from
Dec 2, 2024
Merged

Conversation

vincetran
Copy link
Member

Description of changes:

This adds all of the Android documentation for Passwordless. The tip of main has already been merged into this branch so everything should be up-to-date as of this posting.

Related GitHub issue #, if available:

Instructions

If this PR should not be merged upon approval for any reason, please submit as a DRAFT

Which product(s) are affected by this PR (if applicable)?

  • amplify-cli
  • amplify-ui
  • amplify-studio
  • amplify-hosting
  • amplify-libraries

Which platform(s) are affected by this PR (if applicable)?

  • JS
  • Swift
  • Android
  • Flutter
  • React Native

Please add the product(s)/platform(s) affected to the PR title

Checks

  • Does this PR conform to the styleguide?

  • Does this PR include filetypes other than markdown or images? Please add or update unit tests accordingly.

  • Are any files being deleted with this PR? If so, have the needed redirects been created?

  • Are all links in MDX files using the MDX link syntax rather than HTML link syntax?

    ref: MDX: [link](https://docs.amplify.aws/)
    HTML: <a href="https://docs.amplify.aws/">link</a>

When this PR is ready to merge, please check the box below

  • Ready to merge

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@vincetran vincetran requested review from josefaidt and a team as code owners November 27, 2024 23:31
Comment on lines +619 to +638

```ts title="amplify/backend.ts"
import { defineBackend } from '@aws-amplify/backend'
import { auth } from './auth/resource'
import { data } from './data/resource'

const backend = defineBackend({
auth,
data,
});

// highlight-start
backend.auth.resources.cfnResources.cfnUserPoolClient.explicitAuthFlows = [
"ALLOW_USER_PASSWORD_AUTH",
"ALLOW_USER_SRP_AUTH",
"ALLOW_USER_AUTH",
"ALLOW_REFRESH_TOKEN_AUTH"
];
// highlight-end
```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest that we navigate them to other page which has this example already defined on how to setup the backend for passwordless.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't speak for Matt who wrote this part, but the section you called out is under the USER_PASSWORD_AUTH section of the documentation. In fact this section is what exists on the Swift side today. �

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 to moving this into the overrides section with a callout in this section pointing to the other doc. We have a callout elsewhere with a link to the github issue tracking the feature request that can be reused

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@josefaidt Where is the overrides section? And I'm confused why we would want to add the the Github for USER_AUTH when this sectino is for USER_PASSWORD_AUTH.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed this section entirely as per a conversation with @josefaidt

vincetran and others added 2 commits November 29, 2024 10:17
tylerjroach
tylerjroach previously approved these changes Nov 29, 2024
harsh62
harsh62 previously approved these changes Nov 29, 2024
@vincetran vincetran dismissed stale reviews from harsh62 and tylerjroach via 23575cd November 29, 2024 22:58
@harsh62 harsh62 enabled auto-merge (squash) December 2, 2024 18:22
@harsh62 harsh62 merged commit 64403cf into main Dec 2, 2024
12 checks passed
@harsh62 harsh62 deleted the add-passwordless-android branch December 2, 2024 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants