Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add passwordless #8127

Merged
merged 17 commits into from
Nov 26, 2024
Merged

Add passwordless #8127

merged 17 commits into from
Nov 26, 2024

Conversation

josefaidt
Copy link
Contributor

Description of changes:

Related GitHub issue #, if available:

Instructions

If this PR should not be merged upon approval for any reason, please submit as a DRAFT

Which product(s) are affected by this PR (if applicable)?

  • amplify-cli
  • amplify-ui
  • amplify-studio
  • amplify-hosting
  • amplify-libraries

Which platform(s) are affected by this PR (if applicable)?

  • JS
  • Swift
  • Android
  • Flutter
  • React Native

Please add the product(s)/platform(s) affected to the PR title

Checks

  • Does this PR conform to the styleguide?

  • Does this PR include filetypes other than markdown or images? Please add or update unit tests accordingly.

  • Are any files being deleted with this PR? If so, have the needed redirects been created?

  • Are all links in MDX files using the MDX link syntax rather than HTML link syntax?

    ref: MDX: [link](https://docs.amplify.aws/)
    HTML: <a href="https://docs.amplify.aws/">link</a>

When this PR is ready to merge, please check the box below

  • Ready to merge

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

mattcreaser
mattcreaser reviewed Nov 25, 2024
View reviewed changes
src/pages/[platform]/build-a-backend/auth/connect-your-frontend/sign-up/index.mdx Outdated

</InlineFilter>

### WebAuthn Passkeys
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be able to remove this information as it's not possible to sign-up via passkey - passkeys can only be registered after creating an account and signing in with one of the other methods.

harsh62
harsh62 reviewed Nov 25, 2024
View reviewed changes
src/pages/[platform]/build-a-backend/auth/manage-users/manage-passwords/index.mdx Outdated
@@ -544,3 +544,6 @@ cfnUserPool.policies = {
},
};
```

## Add passwords to passwordless users
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are removing this page for the time being.

scanlonp and others added 3 commits November 26, 2024 13:28
@scanlonp @jjarvisp @josefaidt
chore(auth): add js passwordless changes (#8129)
91241f7 
* chore(auth): add js passwordless changes

* chore(auth): add filters and a react-native callout; code spacing

* chore(auth): add sign in updates

* Update src/pages/[platform]/build-a-backend/auth/manage-users/manage-webauthn-credentials/index.mdx

Co-authored-by: James Jarvis <[email protected]>

* chore(auth): add associate api to the manage webauthn page

* Update src/pages/[platform]/build-a-backend/auth/connect-your-frontend/sign-in/index.mdx

Co-authored-by: josef <[email protected]>

* chore(auth): use string literals

* chore(auth): add signin next step types

* add js sign up examples

* chore(auth): improve wording

* chore(auth): add first factor selection to confirm sign-in next steps

* Update src/pages/[platform]/build-a-backend/auth/connect-your-frontend/sign-in/index.mdx

Co-authored-by: James Jarvis <[email protected]>

* Update src/pages/[platform]/build-a-backend/auth/connect-your-frontend/sign-in/index.mdx

Co-authored-by: James Jarvis <[email protected]>

* chore(auth): review feedback - formatting and wording

* chore(auth): move user auth flow info into switching flows page

---------

Co-authored-by: James Jarvis <[email protected]>
Co-authored-by: josef <[email protected]>
@josefaidt
merge main
8c3ef69
@jjarvisp
resolve structural issues
7101a87
@josefaidt josefaidt marked this pull request as ready for review November 26, 2024 22:46
@josefaidt josefaidt requested review from a team as code owners November 26, 2024 22:46
dbanksdesign
dbanksdesign approved these changes Nov 26, 2024
View reviewed changes
Copy link
Contributor

@dbanksdesign dbanksdesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just make sure to go back and fill in the empty spots

src/pages/[platform]/build-a-backend/auth/concepts/passwordless/index.mdx
- [WebAuthn passkey](#webauthn-passkey)

Passwordless authentication removes the security risks and user friction associated with traditional passwords.
{/* add more color */}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

src/pages/[platform]/build-a-backend/auth/concepts/passwordless/index.mdx

</Callout>

{/* need a section about what a "preferred" factor is */}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

src/pages/[platform]/build-a-backend/auth/concepts/passwordless/index.mdx
{/* quick blurb of basic usage */}
<InlineFilter filters={["angular", "javascript", "nextjs", "react", "react-native", "vue"]}>

{/* */}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

@josefaidt josefaidt enabled auto-merge (squash) November 26, 2024 23:54
@josefaidt josefaidt merged commit c863841 into main Nov 26, 2024
12 checks passed
@josefaidt josefaidt deleted the add-passwordless branch November 26, 2024 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harsh62 harsh62 harsh62 left review comments

@mattcreaser mattcreaser mattcreaser left review comments

@jjarvisp jjarvisp jjarvisp approved these changes

@dbanksdesign dbanksdesign dbanksdesign approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@josefaidt @dbanksdesign @mattcreaser @harsh62 @jjarvisp @thisisabhash @scanlonp