Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): Updating docs to reflect TOTP support in Authenticator for Swift #4615

Merged
merged 1 commit into from
Nov 1, 2023

Conversation

harsh62
Copy link
Member

@harsh62 harsh62 commented Oct 31, 2023

Description of changes

The PR aims to update docs to add details of TOTP in Authenticator for Swift. The changes updates the following 2 things:

  • How a customer can pass in a configuration to udpate the issuer.
  • How a customer can customize the TOTP Setup Experience.

Checklist

  • Have read the Pull Request Guidelines
  • PR description included
  • Relevant documentation is changed or added (and PR referenced)
  • yarn test passes and tests are updated/added
  • No side effects or sideEffects field updated

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@harsh62 harsh62 requested a review from a team as a code owner October 31, 2023 14:48
Copy link

changeset-bot bot commented Oct 31, 2023

⚠️ No Changeset found

Latest commit: e53f118

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@harsh62 harsh62 temporarily deployed to ci October 31, 2023 15:09 — with GitHub Actions Inactive
@harsh62 harsh62 temporarily deployed to ci October 31, 2023 15:09 — with GitHub Actions Inactive
@harsh62 harsh62 temporarily deployed to ci October 31, 2023 15:09 — with GitHub Actions Inactive
@harsh62 harsh62 temporarily deployed to ci October 31, 2023 15:09 — with GitHub Actions Inactive
Copy link
Contributor

@abdallahshaban557 abdallahshaban557 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@harsh62
Copy link
Member Author

harsh62 commented Nov 1, 2023

TOTP PR has been merged. aws-amplify/amplify-ui-swift-authenticator#43

@harsh62
Copy link
Member Author

harsh62 commented Nov 1, 2023

Released TOTP Support in Authenticator for Swift
https://github.com/aws-amplify/amplify-ui-swift-authenticator/releases/tag/1.1.0 .. This PR Is ready to be merged.

@calebpollman calebpollman merged commit 46161e5 into main Nov 1, 2023
29 checks passed
@calebpollman calebpollman deleted the feat/adding-totp-docs-swift-authenticator branch November 1, 2023 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants