chore(liveness): move liveness example app to its own app (#4451) #4462
Conversation
* chore(liveness): move liveness example app to its own app * address feedback * uppgrade outdated deps * Update examples/next-liveness/.eslintrc Co-authored-by: Caleb Pollman <[email protected]> --------- Co-authored-by: Caleb Pollman <[email protected]>
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| "../../environments/*" | ||
| ] | ||
| }, | ||
| "incremental": true |
There was a problem hiding this comment.
Might have missed this is the prior review but is incremental now required?
There was a problem hiding this comment.
think this may have automatically been added when upgrading next, im not sure if it's needed will check
| "react-copy-to-clipboard": "^5.1.0", | ||
| "react-dom": "18", | ||
| "react-icons": "^4.4.0", | ||
| "react-map-gl": "7.0.23", |
There was a problem hiding this comment.
Do we need react-map-gl for testing Liveness?
There was a problem hiding this comment.
nope good catch, will remove
| "@types/node": "^15.12.4", | ||
| "@types/react": "^18.2.22", | ||
| "eslint": "^8.44.0", | ||
| "eslint-config-next": "11.0.1", |
There was a problem hiding this comment.
Think the plugin major version might be meant to align with the major version of NextJS
| "next-global-css": "^1.1.1", | ||
| "react": "17", | ||
| "react": "18", | ||
| "react-copy-to-clipboard": "^5.1.0", |
There was a problem hiding this comment.
Think this is no longer needed?
There was a problem hiding this comment.
I saw some issues with no hoisting react between the two different example apps and figured I may as well upgrade next/react on both example apps.
There was a problem hiding this comment.
Meant that clipboard dep since it was just for the Liveness app (i think)
|
@calebpollman tested on this branch and rn android seemed to work |
|
Closing this as we are going to maintain liveness v5 on a separate branch |
chore(liveness): move liveness example app to its own app
address feedback
uppgrade outdated deps
Update examples/next-liveness/.eslintrc
Description of changes
Issue #, if available
Description of how you validated changes
Checklist
yarn testpasses and tests are updated/addedsideEffectsfield updatedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.