fix(docs): add scroll-margin-start to PageTabs #4406
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
When keyboard navigating the docs, the top of the tabpanel that wraps our page layout gets cut off by the sticky nav.
scroll-margin-block-start
to that tabpanel (similar to what we do for our headings)Tested locally on large-ish and small-ish viewports, and while zoomed in/out.
Before
CleanShot.2023-08-31.at.15.55.31.mp4
After
CleanShot.2023-08-31.at.15.58.33.mp4
Issue #, if available
Description of how you validated changes
Checklist
yarn test
passes and tests are updated/addedsideEffects
field updatedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.