Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): add scroll-margin-start to PageTabs #4406

Merged
merged 3 commits into from
Sep 21, 2023
Merged

Conversation

hbuchel
Copy link
Contributor

@hbuchel hbuchel commented Aug 31, 2023

Description of changes

When keyboard navigating the docs, the top of the tabpanel that wraps our page layout gets cut off by the sticky nav.

  • This adds scroll-margin-block-start to that tabpanel (similar to what we do for our headings)
  • Because of that new scroll-margin, another had to be added to scroll back to the top of the page when you are reverse keyboard navigating because it was causing the links above it to be hidden. 🤔 I added some comments alongside the code.

Tested locally on large-ish and small-ish viewports, and while zoomed in/out.

Before

CleanShot.2023-08-31.at.15.55.31.mp4

After

CleanShot.2023-08-31.at.15.58.33.mp4

Issue #, if available

Description of how you validated changes

Checklist

  • Have read the Pull Request Guidelines
  • PR description included
  • Relevant documentation is changed or added (and PR referenced)
  • yarn test passes and tests are updated/added
  • No side effects or sideEffects field updated

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@hbuchel hbuchel requested a review from a team as a code owner August 31, 2023 20:10
@changeset-bot
Copy link

changeset-bot bot commented Aug 31, 2023

⚠️ No Changeset found

Latest commit: c491f9b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@hbuchel hbuchel temporarily deployed to ci August 31, 2023 20:27 — with GitHub Actions Inactive
@hbuchel hbuchel temporarily deployed to ci August 31, 2023 20:27 — with GitHub Actions Inactive
@hbuchel hbuchel temporarily deployed to ci August 31, 2023 20:27 — with GitHub Actions Inactive
@hbuchel hbuchel temporarily deployed to ci August 31, 2023 20:28 — with GitHub Actions Inactive
@hbuchel hbuchel temporarily deployed to ci September 7, 2023 14:45 — with GitHub Actions Inactive
@hbuchel hbuchel temporarily deployed to ci September 7, 2023 14:45 — with GitHub Actions Inactive
@hbuchel hbuchel temporarily deployed to ci September 8, 2023 15:21 — with GitHub Actions Inactive
@hbuchel hbuchel temporarily deployed to ci September 8, 2023 15:21 — with GitHub Actions Inactive
@hbuchel hbuchel temporarily deployed to ci September 8, 2023 15:21 — with GitHub Actions Inactive
@hbuchel hbuchel temporarily deployed to ci September 18, 2023 19:32 — with GitHub Actions Inactive
@hbuchel hbuchel temporarily deployed to ci September 18, 2023 19:32 — with GitHub Actions Inactive
@hbuchel hbuchel temporarily deployed to ci September 18, 2023 19:32 — with GitHub Actions Inactive
@hbuchel hbuchel temporarily deployed to ci September 18, 2023 19:32 — with GitHub Actions Inactive
@hbuchel hbuchel merged commit edf19f4 into main Sep 21, 2023
28 checks passed
@hbuchel hbuchel deleted the DocsTabsScrollMargin branch September 21, 2023 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants