Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update missing localization strings for face not prepared reasons #79

Merged
merged 10 commits into from
Nov 29, 2023

Conversation

phantumcode
Copy link
Contributor

Issue #, if available:
#76

Description of changes:

  • Add localization string for FaceNotPreparedReason string values

Check points: (check or cross out if not relevant)

  • Added new tests to cover change, if needed
  • Build succeeds with all target using Swift Package Manager
  • All unit tests pass
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Documentation update for the change if required
  • PR title conforms to conventional commit style
  • If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@phantumcode phantumcode requested review from a team as code owners November 16, 2023 20:15
Base automatically changed from feat/ux_updates to main November 29, 2023 18:51
@phantumcode phantumcode merged commit 15de0d1 into main Nov 29, 2023
6 checks passed
@phantumcode phantumcode deleted the chore/update_localization branch November 29, 2023 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants