Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle error on loading view #154

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

thisisabhash
Copy link
Member

Issue #, if available:
None

Description of changes:

  • Add error handling on Loading View
  • Resolve below compiler warning:
    Accessing StateObject's object without being installed on a View. This will create a new instance each time.

Check points: (check or cross out if not relevant)

  • Added new tests to cover change, if needed
  • Build succeeds with all target using Swift Package Manager
  • All unit tests pass
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Documentation update for the change if required
  • PR title conforms to conventional commit style
  • If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@thisisabhash thisisabhash requested review from a team as code owners July 2, 2024 18:12
@thisisabhash thisisabhash merged commit 49b620c into feat/no-light-support Jul 2, 2024
4 checks passed
@thisisabhash thisisabhash deleted the fix/handle-error-loading-view branch July 2, 2024 18:29
thisisabhash added a commit that referenced this pull request Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants