Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: theme support for text fields input and place holder values #100

Merged
merged 2 commits into from
Dec 10, 2024

Conversation

harsh62
Copy link
Member

@harsh62 harsh62 commented Dec 2, 2024

Description of changes:

Making Text Fields follow the Authenticator theme.

  • The input values theme would now map to theme.colors.foreground.secondary
  • The placeholder values theme now map to theme.colors.foreground.disabled

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@harsh62 harsh62 requested review from a team as code owners December 2, 2024 16:43
Copy link

codecov bot commented Dec 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.46%. Comparing base (a94155b) to head (b513498).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #100   +/-   ##
=======================================
  Coverage   44.46%   44.46%           
=======================================
  Files          43       43           
  Lines        2456     2456           
=======================================
  Hits         1092     1092           
  Misses       1364     1364           
Flag Coverage Δ
Authenticator 44.46% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@harsh62 harsh62 merged commit a18f030 into main Dec 10, 2024
5 checks passed
@harsh62 harsh62 deleted the text-field-theme branch December 10, 2024 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants