Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Storage): Adding StorageBucket #3812

Merged
merged 2 commits into from
Aug 14, 2024

Conversation

ruisebas
Copy link
Member

Description

This PR adds the new StorageBucket protocol and its default implementations.
It also adds an optional bucket: StorageBucket parameter to the existing Request.Options enums.

General Checklist

  • Added new tests to cover change, if needed
  • Build succeeds with all target using Swift Package Manager
  • All unit tests pass
  • All integration tests pass
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Documentation update for the change if required
  • PR title conforms to conventional commit style
  • New or updated tests include Given When Then inline code documentation and are named accordingly testThing_condition_expectation()
  • If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ruisebas ruisebas requested a review from a team as a code owner August 13, 2024 15:34
Copy link
Contributor

API Breakage Report

💔 Public API Breaking Change detected:

Module: Amplify
Constructor StorageDownloadDataRequest.Options.init(accessLevel:targetIdentityId:pluginOptions:) has been removed
Constructor StorageDownloadDataRequest.Options.init(pluginOptions:) has been removed
Constructor StorageDownloadFileRequest.Options.init(accessLevel:targetIdentityId:pluginOptions:) has been removed
Constructor StorageDownloadFileRequest.Options.init(pluginOptions:) has been removed
Constructor StorageGetURLRequest.Options.init(accessLevel:targetIdentityId:expires:pluginOptions:) has been removed
Constructor StorageGetURLRequest.Options.init(expires:pluginOptions:) has been removed
Constructor StorageListRequest.Options.init(accessLevel:targetIdentityId:path:subpathStrategy:pageSize:nextToken:pluginOptions:) has been removed
Constructor StorageRemoveRequest.Options.init(accessLevel:pluginOptions:) has been removed
Constructor StorageUploadDataRequest.Options.init(accessLevel:targetIdentityId:metadata:contentType:pluginOptions:) has been removed
Constructor StorageUploadDataRequest.Options.init(metadata:contentType:pluginOptions:) has been removed
Constructor StorageUploadFileRequest.Options.init(accessLevel:targetIdentityId:metadata:contentType:pluginOptions:) has been removed
Constructor StorageUploadFileRequest.Options.init(metadata:contentType:pluginOptions:) has been removed

@github-actions github-actions bot requested a review from a team as a code owner August 13, 2024 15:41
@ruisebas ruisebas merged commit f012197 into feature/multibucket-storage Aug 14, 2024
@ruisebas ruisebas deleted the ruisebas/storagebucket_imp branch August 14, 2024 17:56
ruisebas added a commit that referenced this pull request Aug 27, 2024
ruisebas added a commit that referenced this pull request Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants