Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update rexml to 3.3.2 #3783

Closed
wants to merge 3 commits into from
Closed

chore: update rexml to 3.3.2 #3783

wants to merge 3 commits into from

Conversation

lawmicha
Copy link
Contributor

@lawmicha lawmicha commented Jul 17, 2024

Issue #

Description

  1. Pin rexml to 3.3.2 and greater
  2. Remove exact versions of fastlane and jazzy to allow pinning activesupport to previous resolved version 7.0.7.2 and greater
  • jazzy looks like has been resolved to a lower version. 0.9.4 from 0.14.2. I think we need to confirm jazzy docs still functions as expected.

  • json was pinned to previous version (2.6.3) in second commit. First commit has issue with the license

The following dependencies have incompatible licenses:
  Gemfile.lock » [email protected] – License: Ruby OR (BSD-2-Clause AND Ruby)

Second commit still has issues on the license

Gemfile » [email protected] – License: Ruby OR (BSD-2-Clause AND Ruby)
  Error: Dependency review detected incompatible licenses.

General Checklist

  • Added new tests to cover change, if needed
  • Build succeeds with all target using Swift Package Manager
  • All unit tests pass
  • All integration tests pass
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Documentation update for the change if required
  • PR title conforms to conventional commit style
  • New or updated tests include Given When Then inline code documentation and are named accordingly testThing_condition_expectation()
  • If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Contributor

API Breakage Report

✅ No Public API Breaking Change detected

Copy link

codecov bot commented Jul 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.48%. Comparing base (a8beec8) to head (e9174d4).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3783      +/-   ##
==========================================
- Coverage   68.50%   68.48%   -0.02%     
==========================================
  Files        1079     1079              
  Lines       37591    37591              
==========================================
- Hits        25752    25745       -7     
- Misses      11839    11846       +7     
Flag Coverage Δ
API_plugin_unit_test 68.83% <ø> (ø)
AWSPluginsCore 68.56% <ø> (ø)
Amplify 47.56% <ø> (ø)
Analytics_plugin_unit_test 84.52% <ø> (ø)
Auth_plugin_unit_test 79.69% <ø> (-0.06%) ⬇️
DataStore_plugin_unit_test 81.17% <ø> (-0.02%) ⬇️
Geo_plugin_unit_test 72.00% <ø> (ø)
Logging_plugin_unit_test 62.95% <ø> (ø)
Predictions_plugin_unit_test 37.32% <ø> (ø)
PushNotifications_plugin_unit_test 86.21% <ø> (ø)
Storage_plugin_unit_test 76.75% <ø> (ø)
unit_tests 68.48% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

API Breakage Report

✅ No Public API Breaking Change detected

claide (1.1.0)
cocoapods (1.12.0)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cocoapods 1.0.1 is from June 02, 2016.
I think that's also a significant downgrade 😕

@harsh62 harsh62 closed this Jul 22, 2024
@harsh62 harsh62 reopened this Jul 22, 2024
@harsh62 harsh62 closed this Jul 22, 2024
Copy link
Contributor

API Breakage Report

💔 Public API Breaking Change detected:

Module: Amplify
Constructor StorageListRequest.Options.init(accessLevel:targetIdentityId:path:pageSize:nextToken:pluginOptions:) has been removed
Constructor StorageListResult.init(items:nextToken:) has been removed

@harsh62 harsh62 reopened this Jul 22, 2024
Copy link
Contributor

API Breakage Report

💔 Public API Breaking Change detected:

Module: Amplify
Constructor StorageListRequest.Options.init(accessLevel:targetIdentityId:path:pageSize:nextToken:pluginOptions:) has been removed
Constructor StorageListResult.init(items:nextToken:) has been removed

1 similar comment
Copy link
Contributor

API Breakage Report

💔 Public API Breaking Change detected:

Module: Amplify
Constructor StorageListRequest.Options.init(accessLevel:targetIdentityId:path:pageSize:nextToken:pluginOptions:) has been removed
Constructor StorageListResult.init(items:nextToken:) has been removed

@ruisebas ruisebas closed this Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants