-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: resolve strict concurrency errors #3731
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3731 +/- ##
==========================================
+ Coverage 68.41% 68.59% +0.17%
==========================================
Files 1079 1079
Lines 37563 37569 +6
==========================================
+ Hits 25699 25769 +70
+ Misses 11864 11800 -64
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
AmplifyPlugins/Internal/Sources/InternalAWSPinpoint/Context/PinpointContext.swift
Show resolved
Hide resolved
AmplifyPlugins/Internal/Sources/InternalAWSPinpoint/Endpoint/EndpointInformation.swift
Show resolved
Hide resolved
...ugins/Logging/Sources/AWSCloudWatchLoggingPlugin/AWSCloudWatchLoggingSessionController.swift
Outdated
Show resolved
Hide resolved
.../AWSCloudWatchLoggingPluginIntegrationTests/AWSCloudWatchLoggingPluginIntegrationTests.swift
Outdated
Show resolved
Hide resolved
...WSCognitoAuthPlugin/Actions/RefreshAuthorizationSession/UserPool/RefreshUserPoolTokens.swift
Show resolved
Hide resolved
...yPlugins/Logging/Sources/AWSCloudWatchLoggingPlugin/Consumer/CloudWatchLoggingConsumer.swift
Show resolved
Hide resolved
AmplifyPlugins/Internal/Tests/InternalAWSPinpointUnitTests/ActivityTrackerTests.swift
Show resolved
Hide resolved
AmplifyPlugins/Internal/Sources/InternalAWSPinpoint/Endpoint/EndpointInformation.swift
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A reminder to merge this in as a fix
or feat
since chore
commits do not show up in the changelog, and they usually non-production related code changes https://devops.stackexchange.com/a/19067
Issue #
Description
Resolving errors in various categories when strict concurrency and Swift 6 experimental settings are enabled
Change details:
Amplify Core
UIDevice
inDeviceInfo
from an main-actor isolated contextDevMenu
resolve issues with referencing main-actor isolated context from a synchronus nonisolated contextAmplifyPlugins/Core
AWSServiceConfiguration
to calculate the user agent value in an main-actor isolated context as a result of changes to Amplify CoreAmplifyPlugins Auth
ASFDeviceInfo
referencingDeviceInfo
ASFDeviceInfo
in an async isolated contextAmplifyPlugins InternalAWSPinpoint
EndpointInformation
EndpointInformation
to be a struct and introducedEndpointInformationProvider
interface and implementation so that calling hierarchy can execute and getEndpointInformation
in an async isolated contextAmplifyPlugins Logging
CloudWatchLoggingStreamNameFormatter
needs to calculate the device identifier to calculate the log stream name in an async isolated context. Updated and refactor logging logic to calculate the log stream name at the time of usage so that it can be called in an async isolated context while limiting cascading changes.AmplifyPlugins Storage
AWSServiceConfiguration
in AmplifyPluginsCore which requires main-actor isolated context execution. Updating theStorageServiceProxy
to provideuserAgent
computed property in an async context. Implementation and references toStorageServiceProxy
to get theuserAgent
property is also updated to execute in an async context.Testing details:
General Checklist
Given When Then
inline code documentation and are named accordinglytestThing_condition_expectation()
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.