Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(logging): no log should be logged when loglevel is none #3728

Merged
merged 3 commits into from
May 29, 2024

Conversation

5d
Copy link
Member

@5d 5d commented May 29, 2024

Issue #

#3727

Description

The log level .none should not produce any logs, but it is currently misplaced in the LogLevel enum and has the same effect as .verbose.
In this PR, we have updated .none to be lower than the .error log level. Additionally, we have added a log level check guard condition in the log.error API.

General Checklist

  • Added new tests to cover change, if needed
  • Build succeeds with all target using Swift Package Manager
  • All unit tests pass
  • All integration tests pass
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Documentation update for the change if required
  • PR title conforms to conventional commit style
  • New or updated tests include Given When Then inline code documentation and are named accordingly testThing_condition_expectation()
  • If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@5d 5d requested a review from a team as a code owner May 29, 2024 19:21
@5d 5d temporarily deployed to IntegrationTest May 29, 2024 19:46 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest May 29, 2024 19:46 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest May 29, 2024 19:46 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest May 29, 2024 19:46 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest May 29, 2024 19:46 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest May 29, 2024 19:46 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest May 29, 2024 19:46 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest May 29, 2024 19:46 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest May 29, 2024 19:46 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest May 29, 2024 19:46 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest May 29, 2024 19:46 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest May 29, 2024 19:46 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest May 29, 2024 19:46 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest May 29, 2024 19:46 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest May 29, 2024 19:46 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest May 29, 2024 19:46 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest May 29, 2024 19:46 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest May 29, 2024 19:46 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest May 29, 2024 19:46 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest May 29, 2024 19:46 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest May 29, 2024 19:46 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest May 29, 2024 19:46 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest May 29, 2024 19:46 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest May 29, 2024 19:46 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest May 29, 2024 19:46 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest May 29, 2024 19:46 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest May 29, 2024 19:46 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest May 29, 2024 19:46 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest May 29, 2024 19:46 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest May 29, 2024 19:46 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest May 29, 2024 19:46 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest May 29, 2024 19:46 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest May 29, 2024 19:46 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest May 29, 2024 19:46 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest May 29, 2024 19:46 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest May 29, 2024 19:46 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest May 29, 2024 19:46 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest May 29, 2024 19:47 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest May 29, 2024 19:47 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest May 29, 2024 19:47 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest May 29, 2024 19:47 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest May 29, 2024 19:47 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest May 29, 2024 19:47 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest May 29, 2024 19:47 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest May 29, 2024 19:47 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest May 29, 2024 19:47 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest May 29, 2024 19:47 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest May 29, 2024 19:47 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest May 29, 2024 19:47 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest May 29, 2024 19:47 — with GitHub Actions Inactive
Copy link

codecov bot commented May 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.41%. Comparing base (9550b56) to head (b918b56).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3728      +/-   ##
==========================================
+ Coverage   68.39%   68.41%   +0.02%     
==========================================
  Files        1089     1089              
  Lines       37651    37651              
==========================================
+ Hits        25750    25760      +10     
+ Misses      11901    11891      -10     
Flag Coverage Δ
API_plugin_unit_test 68.97% <ø> (+0.21%) ⬆️
AWSPluginsCore 65.81% <ø> (ø)
Amplify 48.17% <100.00%> (+0.03%) ⬆️
Analytics_plugin_unit_test 84.52% <ø> (ø)
Auth_plugin_unit_test 79.34% <ø> (ø)
DataStore_plugin_unit_test 81.39% <ø> (+0.01%) ⬆️
Geo_plugin_unit_test 72.00% <ø> (ø)
Logging_plugin_unit_test 62.87% <ø> (ø)
Predictions_plugin_unit_test 37.32% <ø> (ø)
PushNotifications_plugin_unit_test 86.21% <ø> (ø)
Storage_plugin_unit_test 76.75% <ø> (ø)
unit_tests 68.41% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@5d 5d merged commit ef085ad into main May 29, 2024
136 checks passed
@5d 5d deleted the 5d/fix-loglevel-none branch May 29, 2024 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants