Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(API): make sure unsubscribe is invoked when subscription cancelled #3619

Merged
merged 2 commits into from
Apr 18, 2024

Conversation

5d
Copy link
Member

@5d 5d commented Apr 17, 2024

Issue #

Description

This PR addresses a similar issue to PR #3615, it fixes the AWSGraphQLSubscriptionOperation to ensure that the unsubscribe method is called during the cancellation of the operation. Additionally, an integration test case has been added to verify that subscriptions are properly unsubscribed and removed from the AppSyncRealTimeClient.

General Checklist

  • Added new tests to cover change, if needed
  • Build succeeds with all target using Swift Package Manager
  • All unit tests pass
  • All integration tests pass
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Documentation update for the change if required
  • PR title conforms to conventional commit style
  • New or updated tests include Given When Then inline code documentation and are named accordingly testThing_condition_expectation()
  • If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@5d 5d force-pushed the 5d/fix-subscription-cancel branch from 73cc842 to d4ee943 Compare April 17, 2024 03:04
@5d 5d marked this pull request as ready for review April 17, 2024 03:24
@5d 5d requested a review from a team as a code owner April 17, 2024 03:24
@5d 5d temporarily deployed to IntegrationTest April 17, 2024 03:25 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest April 17, 2024 03:25 — with GitHub Actions Inactive
@5d 5d had a problem deploying to IntegrationTest April 17, 2024 03:25 — with GitHub Actions Failure
@5d 5d temporarily deployed to IntegrationTest April 17, 2024 03:25 — with GitHub Actions Inactive
@5d 5d had a problem deploying to IntegrationTest April 17, 2024 03:25 — with GitHub Actions Failure
@5d 5d temporarily deployed to IntegrationTest April 17, 2024 03:25 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest April 17, 2024 03:25 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest April 17, 2024 03:25 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest April 17, 2024 03:25 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest April 17, 2024 03:25 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest April 17, 2024 03:25 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest April 17, 2024 03:25 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest April 17, 2024 03:25 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest April 17, 2024 03:25 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest April 17, 2024 03:25 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest April 17, 2024 03:25 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest April 17, 2024 03:25 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest April 17, 2024 03:25 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest April 17, 2024 03:25 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest April 17, 2024 03:25 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest April 17, 2024 03:25 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest April 17, 2024 03:25 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest April 17, 2024 03:25 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest April 17, 2024 03:25 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest April 17, 2024 03:25 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest April 18, 2024 17:25 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest April 18, 2024 17:25 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest April 18, 2024 17:25 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest April 18, 2024 17:25 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest April 18, 2024 17:25 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest April 18, 2024 17:25 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest April 18, 2024 17:25 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest April 18, 2024 17:46 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest April 18, 2024 17:46 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest April 18, 2024 17:46 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest April 18, 2024 17:46 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest April 18, 2024 17:46 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest April 18, 2024 17:47 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest April 18, 2024 17:47 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest April 18, 2024 17:47 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest April 18, 2024 17:47 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest April 18, 2024 17:47 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest April 18, 2024 17:47 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest April 18, 2024 17:47 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest April 18, 2024 17:47 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest April 18, 2024 17:47 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest April 18, 2024 17:47 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest April 18, 2024 17:47 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest April 18, 2024 17:47 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest April 18, 2024 17:47 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest April 18, 2024 17:47 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest April 18, 2024 17:47 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest April 18, 2024 17:47 — with GitHub Actions Inactive
@5d 5d merged commit e38ba53 into main Apr 18, 2024
135 checks passed
@5d 5d deleted the 5d/fix-subscription-cancel branch April 18, 2024 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants