Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: amplify network package #3583

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

chore: amplify network package #3583

wants to merge 10 commits into from

Conversation

5d
Copy link
Member

@5d 5d commented Mar 22, 2024

Issue #

Description

  • created a new internal package with name AmplifyNetwork
  • move WebSocketClient module to AmplifyNetwork

General Checklist

  • Added new tests to cover change, if needed
  • Build succeeds with all target using Swift Package Manager
  • All unit tests pass
  • All integration tests pass
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Documentation update for the change if required
  • PR title conforms to conventional commit style
  • New or updated tests include Given When Then inline code documentation and are named accordingly testThing_condition_expectation()
  • If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-commenter
Copy link

codecov-commenter commented Mar 22, 2024

Codecov Report

Attention: Patch coverage is 93.10345% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 68.38%. Comparing base (d6d5a23) to head (a2cf85a).
Report is 1 commits behind head on main.

Files Patch % Lines
.../AppSyncRealTimeClient/AppSyncRealTimeClient.swift 60.00% 2 Missing ⚠️
...ubscriptionInterceptor/APIKeyAuthInterceptor.swift 50.00% 1 Missing ⚠️
...r/SubscriptionInterceptor/IAMAuthInterceptor.swift 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3583      +/-   ##
==========================================
- Coverage   68.48%   68.38%   -0.10%     
==========================================
  Files        1096     1093       -3     
  Lines       38088    37890     -198     
==========================================
- Hits        26084    25911     -173     
+ Misses      12004    11979      -25     
Flag Coverage Δ
API_plugin_unit_test 70.16% <93.10%> (+1.20%) ⬆️
AWSPluginsCore 63.74% <ø> (-1.94%) ⬇️
Amplify 48.19% <ø> (ø)
Analytics_plugin_unit_test 84.52% <ø> (ø)
Auth_plugin_unit_test 79.46% <ø> (+0.18%) ⬆️
CoreMLPredictions_plugin_unit_test 61.15% <ø> (ø)
DataStore_plugin_unit_test 81.40% <ø> (-0.94%) ⬇️
Geo_plugin_unit_test 73.50% <ø> (ø)
Logging_plugin_unit_test 62.87% <ø> (ø)
Predictions_plugin_unit_test 37.32% <ø> (ø)
PushNotifications_plugin_unit_test 86.21% <ø> (ø)
Storage_plugin_unit_test 76.75% <ø> (ø)
unit_tests 68.38% <93.10%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@5d 5d force-pushed the 5d/amplify-network branch from 797711a to 6c99824 Compare March 28, 2024 21:40
@5d 5d temporarily deployed to IntegrationTest March 28, 2024 23:04 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest March 28, 2024 23:04 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest March 28, 2024 23:04 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest March 28, 2024 23:04 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest March 28, 2024 23:04 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest March 28, 2024 23:04 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest March 28, 2024 23:04 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest March 28, 2024 23:04 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest March 28, 2024 23:04 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest March 28, 2024 23:04 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest March 28, 2024 23:04 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest March 28, 2024 23:04 — with GitHub Actions Inactive
@5d 5d had a problem deploying to IntegrationTest March 28, 2024 23:04 — with GitHub Actions Failure
@5d 5d temporarily deployed to IntegrationTest March 28, 2024 23:04 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest March 28, 2024 23:04 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest March 28, 2024 23:04 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest March 28, 2024 23:04 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest March 28, 2024 23:04 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest March 28, 2024 23:04 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest March 28, 2024 23:04 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest March 28, 2024 23:04 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest May 17, 2024 18:06 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest May 17, 2024 18:06 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest May 17, 2024 18:06 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest May 17, 2024 18:06 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest May 17, 2024 18:06 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest May 17, 2024 18:06 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest May 17, 2024 18:06 — with GitHub Actions Inactive
@5d 5d had a problem deploying to IntegrationTest May 17, 2024 18:06 — with GitHub Actions Failure
@5d 5d temporarily deployed to IntegrationTest May 17, 2024 18:40 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest May 17, 2024 18:40 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest May 17, 2024 18:40 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest May 17, 2024 18:40 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest May 17, 2024 18:41 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest May 17, 2024 18:41 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest May 17, 2024 18:41 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest May 17, 2024 18:41 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest May 17, 2024 18:41 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest May 17, 2024 18:41 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest May 17, 2024 18:41 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest May 17, 2024 18:41 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest May 17, 2024 18:41 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest May 17, 2024 18:41 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest May 17, 2024 18:41 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest May 17, 2024 18:41 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest May 17, 2024 18:41 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest May 17, 2024 18:41 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest May 17, 2024 18:41 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest May 17, 2024 18:41 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest May 17, 2024 18:41 — with GitHub Actions Inactive
@5d 5d requested a review from lawmicha May 21, 2024 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants