Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [v1] Updating minimum deployment target to iOS 12 #3562

Merged
merged 3 commits into from
Apr 30, 2024
Merged

Conversation

ruisebas
Copy link
Member

@ruisebas ruisebas commented Mar 12, 2024

Description

This PR bumps the deployment target to iOS 12 in preparation for some upcoming changes.

General Checklist

  • Added new tests to cover change, if needed
  • Build succeeds with all target using Swift Package Manager
  • All unit tests pass
  • All integration tests pass
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Documentation update for the change if required
  • PR title conforms to conventional commit style
  • New or updated tests include Given When Then inline code documentation and are named accordingly testThing_condition_expectation()
  • If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ruisebas ruisebas requested a review from a team as a code owner March 12, 2024 20:30
lawmicha
lawmicha previously approved these changes Mar 13, 2024
@ruisebas ruisebas merged commit 8e0d54d into v1 Apr 30, 2024
47 checks passed
@ruisebas ruisebas deleted the feat/v1-ios12 branch April 30, 2024 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants