Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add swiftlint GH action #3455

Merged
merged 3 commits into from
Jan 4, 2024
Merged

chore: add swiftlint GH action #3455

merged 3 commits into from
Jan 4, 2024

Conversation

phantumcode
Copy link
Contributor

@phantumcode phantumcode commented Jan 4, 2024

Issue #

Description

  • Add .git-blame-ignore-revs file
  • update SwiftLint configuration
  • add SwiftLint GH Action
  • add a convenience xcodeproj that includes swiftlint build phase script

General Checklist

  • Added new tests to cover change, if needed
  • Build succeeds with all target using Swift Package Manager
  • All unit tests pass
  • All integration tests pass
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Documentation update for the change if required
  • PR title conforms to conventional commit style
  • New or updated tests include Given When Then inline code documentation and are named accordingly testThing_condition_expectation()
  • If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-commenter
Copy link

codecov-commenter commented Jan 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (659e861) 68.00% compared to head (7be3a26) 67.83%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3455      +/-   ##
==========================================
- Coverage   68.00%   67.83%   -0.17%     
==========================================
  Files        1078     1078              
  Lines       36296    36296              
==========================================
- Hits        24683    24622      -61     
- Misses      11613    11674      +61     
Flag Coverage Δ
API_plugin_unit_test 67.07% <ø> (ø)
AWSPluginsCore 64.13% <ø> (ø)
Amplify 48.12% <ø> (+0.01%) ⬆️
Analytics_plugin_unit_test 81.16% <ø> (ø)
Auth_plugin_unit_test 78.96% <ø> (ø)
CoreMLPredictions_plugin_unit_test 59.44% <ø> (ø)
DataStore_plugin_unit_test 80.22% <ø> (-0.94%) ⬇️
Geo_plugin_unit_test 70.75% <ø> (ø)
Logging_plugin_unit_test 63.34% <ø> (ø)
Predictions_plugin_unit_test 37.16% <ø> (ø)
PushNotifications_plugin_unit_test 87.13% <ø> (ø)
Storage_plugin_unit_test 77.51% <ø> (ø)
unit_tests 67.83% <ø> (-0.17%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@phantumcode phantumcode changed the title [DRAFT] chore: add swiftlint GH action chore: add swiftlint GH action Jan 4, 2024
@phantumcode phantumcode marked this pull request as ready for review January 4, 2024 18:44
@phantumcode phantumcode requested a review from a team as a code owner January 4, 2024 18:44
Copy link
Member

@atierian atierian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if I was just holding it wrong, but FYSA I needed to upgrade from SwiftLint 0.48.0 to 0.53.0 for the build script in the xcodeproj to work.

@phantumcode phantumcode merged commit 3b2ceba into main Jan 4, 2024
78 checks passed
@phantumcode phantumcode deleted the chore/enable_swiftlint branch January 4, 2024 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants