Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(datastore): fix datastore ConsecutiveUpdatesTests #3450

Closed
wants to merge 1 commit into from

Conversation

5d
Copy link
Member

@5d 5d commented Jan 2, 2024

Issue #

Description

  • fix broken datastore integration test

General Checklist

  • Added new tests to cover change, if needed
  • Build succeeds with all target using Swift Package Manager
  • All unit tests pass
  • All integration tests pass
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Documentation update for the change if required
  • PR title conforms to conventional commit style
  • New or updated tests include Given When Then inline code documentation and are named accordingly testThing_condition_expectation()
  • If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@5d 5d had a problem deploying to IntegrationTest January 2, 2024 22:35 — with GitHub Actions Failure
@5d 5d temporarily deployed to IntegrationTest January 2, 2024 22:35 — with GitHub Actions Inactive
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a0ee257) 68.13% compared to head (e94911f) 68.15%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3450      +/-   ##
==========================================
+ Coverage   68.13%   68.15%   +0.01%     
==========================================
  Files        1085     1085              
  Lines       36248    36248              
==========================================
+ Hits        24699    24706       +7     
+ Misses      11549    11542       -7     
Flag Coverage Δ
API_plugin_unit_test 67.07% <ø> (ø)
AWSPluginsCore 64.38% <ø> (ø)
Amplify 48.28% <ø> (+0.06%) ⬆️
Analytics_plugin_unit_test 81.16% <ø> (ø)
Auth_plugin_unit_test 79.08% <ø> (+0.05%) ⬆️
CoreMLPredictions_plugin_unit_test 59.44% <ø> (ø)
DataStore_plugin_unit_test 81.23% <ø> (-0.05%) ⬇️
Geo_plugin_unit_test 70.75% <ø> (ø)
Logging_plugin_unit_test 63.22% <ø> (ø)
Predictions_plugin_unit_test 37.29% <ø> (ø)
PushNotifications_plugin_unit_test 87.03% <ø> (ø)
Storage_plugin_unit_test 78.10% <ø> (ø)
unit_tests 68.15% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@5d 5d temporarily deployed to IntegrationTest January 2, 2024 22:35 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 2, 2024 22:35 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 2, 2024 22:35 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 2, 2024 22:35 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 2, 2024 22:35 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 2, 2024 22:35 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 2, 2024 22:35 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 2, 2024 22:35 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 2, 2024 22:35 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 2, 2024 22:35 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 2, 2024 22:35 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 2, 2024 22:35 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 2, 2024 22:35 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 2, 2024 22:35 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 2, 2024 22:35 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 2, 2024 22:35 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 2, 2024 22:35 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 2, 2024 22:35 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 2, 2024 22:36 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 2, 2024 22:36 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 2, 2024 22:49 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 2, 2024 22:49 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 2, 2024 22:49 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 2, 2024 22:49 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 2, 2024 22:49 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 2, 2024 22:49 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 2, 2024 22:49 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 2, 2024 22:49 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 2, 2024 22:49 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 2, 2024 23:08 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 2, 2024 23:08 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 2, 2024 23:08 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 2, 2024 23:08 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 2, 2024 23:08 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 2, 2024 23:08 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 2, 2024 23:08 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 2, 2024 23:08 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 2, 2024 23:08 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 2, 2024 23:08 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 2, 2024 23:08 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 2, 2024 23:08 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 2, 2024 23:08 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 2, 2024 23:08 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 2, 2024 23:08 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 2, 2024 23:08 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 2, 2024 23:08 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 2, 2024 23:08 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 2, 2024 23:08 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 2, 2024 23:08 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 2, 2024 23:08 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 2, 2024 23:08 — with GitHub Actions Inactive
@5d 5d marked this pull request as ready for review January 2, 2024 23:27
@5d 5d requested a review from a team as a code owner January 2, 2024 23:27
if mutationEvent.version == 1 {
if mutationEvent.mutationType == MutationEvent.MutationType.create.rawValue {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you explain why this change?

@5d 5d closed this Jan 3, 2024
@5d 5d deleted the 5d/fix-ds-integ-test branch January 3, 2024 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants