Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(datastore): configure json encoder with sorted key #3418

Merged
merged 1 commit into from
Dec 12, 2023
Merged

fix(datastore): configure json encoder with sorted key #3418

merged 1 commit into from
Dec 12, 2023

Conversation

5d
Copy link
Member

@5d 5d commented Dec 12, 2023 •
edited
Loading

Issue #

Description

#3057

  • configure json encoder with sorted key

General Checklist

  • Added new tests to cover change, if needed
  • Build succeeds with all target using Swift Package Manager
  • All unit tests pass
  • All integration tests pass
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Documentation update for the change if required
  • PR title conforms to conventional commit style
  • New or updated tests include Given When Then inline code documentation and are named accordingly testThing_condition_expectation()
  • If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@5d 5d requested a review from a team as a code owner December 12, 2023 20:43
atierian
atierian approved these changes Dec 12, 2023
View reviewed changes
Copy link
Member

@atierian atierian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@5d 5d merged commit d06905f into v1 Dec 12, 2023
14 checks passed
@5d 5d deleted the 5d/json-encoder-order branch December 12, 2023 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atierian atierian atierian approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@5d @atierian