Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(datastore): Multi auth rule for read subscription #3263

Closed
wants to merge 1 commit into from

Conversation

lawmicha
Copy link
Contributor

@lawmicha lawmicha commented Oct 2, 2023

Issue #

The issue #2873 contains lots of details describing the problem.

Description

See original PR for more details, this is just a cherry-pick of the v1 changes applied on main #3029

General Checklist

  • Added new tests to cover change, if needed
  • Build succeeds with all target using Swift Package Manager
  • All unit tests pass
  • All integration tests pass
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Documentation update for the change if required
  • PR title conforms to conventional commit style
  • New or updated tests include Given When Then inline code documentation and are named accordingly testThing_condition_expectation()
  • If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@lawmicha lawmicha requested a review from a team as a code owner October 2, 2023 20:06
@lawmicha
Copy link
Contributor Author

lawmicha commented Nov 6, 2023

I believe this was done in #3316

@lawmicha lawmicha closed this Nov 6, 2023
@lawmicha lawmicha deleted the lawmicha.fixmultiauth branch November 6, 2023 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant