Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add TodoCognitoMultiOwner to watchOS target for DataStore test #3246

Merged
merged 1 commit into from
Sep 28, 2023

Conversation

lawmicha
Copy link
Contributor

@lawmicha lawmicha commented Sep 28, 2023

Issue #

Related PR with test issue #3223

Description

Test is missing file added to watchOS target (https://github.com/aws-amplify/amplify-swift/actions/runs/6340116424/job/17222695667#logs)

❌  /Users/runner/work/amplify-swift/amplify-swift/AmplifyPlugins/DataStore/Tests/DataStoreHostApp/AWSDataStorePluginAuthCognitoTests/AWSDataStoreCategoryPluginAuthOwnerIntegrationTests.swift:225:47: cannot find 'TodoCognitoMultiOwner' in scope

            ModelRegistry.register(modelType: TodoCognitoMultiOwner.self)
                   ^~~~~~~~~~~~~~~~~~~~~

General Checklist

  • Added new tests to cover change, if needed
  • Build succeeds with all target using Swift Package Manager
  • All unit tests pass
  • All integration tests pass
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Documentation update for the change if required
  • PR title conforms to conventional commit style
  • New or updated tests include Given When Then inline code documentation and are named accordingly testThing_condition_expectation()
  • If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@lawmicha lawmicha requested a review from a team as a code owner September 28, 2023 15:49
@lawmicha lawmicha merged commit feeb054 into main Sep 28, 2023
61 of 62 checks passed
@lawmicha lawmicha deleted the test.todo-watchos-target branch September 28, 2023 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants