Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(logging): add logging plugin integration test #3218

Merged
merged 15 commits into from
Sep 26, 2023

Conversation

phantumcode
Copy link
Contributor

Issue #

Description

  • add logging plugin integration test

General Checklist

  • Added new tests to cover change, if needed
  • Build succeeds with all target using Swift Package Manager
  • All unit tests pass
  • All integration tests pass
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Documentation update for the change if required
  • PR title conforms to conventional commit style
  • New or updated tests include Given When Then inline code documentation and are named accordingly testThing_condition_expectation()
  • If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

* main:
  fix(logging): fix issue with logger namespace not being set (#3213)
  fix(datastore): wrap failures to result when applying remote update events (#3187)
  test(storage): update storage integration test with longer expiration duration (#3208)
  chore: finalize release 2.17.1 [skip ci]
  chore: release 2.17.1 [skip ci]
@phantumcode phantumcode requested a review from a team as a code owner September 12, 2023 14:57
@phantumcode phantumcode temporarily deployed to Fortify September 14, 2023 17:48 — with GitHub Actions Inactive
@codecov-commenter
Copy link

codecov-commenter commented Sep 14, 2023

Codecov Report

Merging #3218 (2da867b) into main (f1b6fa1) will decrease coverage by 0.05%.
Report is 5 commits behind head on main.
The diff coverage is 10.98%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##             main    #3218      +/-   ##
==========================================
- Coverage   64.60%   64.56%   -0.05%     
==========================================
  Files        1091     1094       +3     
  Lines       37071    37240     +169     
==========================================
+ Hits        23951    24045      +94     
- Misses      13120    13195      +75     
Flag Coverage Δ
API_plugin_unit_test 67.10% <ø> (ø)
AWSPluginsCore 66.04% <0.00%> (-3.52%) ⬇️
Amplify 47.86% <ø> (+0.01%) ⬆️
Analytics_plugin_unit_test 86.39% <ø> (ø)
Auth_plugin_unit_test 75.08% <0.00%> (-0.07%) ⬇️
CoreMLPredictions_plugin_unit_test 59.44% <ø> (ø)
DataStore_plugin_unit_test 81.05% <ø> (+1.01%) ⬆️
Geo_plugin_unit_test 54.85% <100.00%> (+0.78%) ⬆️
Logging_plugin_unit_test 63.41% <85.71%> (+0.23%) ⬆️
Predictions_plugin_unit_test 34.87% <0.00%> (-0.31%) ⬇️
PushNotifications_plugin_unit_test 69.69% <ø> (ø)
Storage_plugin_unit_test 54.07% <43.75%> (-0.04%) ⬇️
unit_tests 64.56% <10.98%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...itoAuthPlugin/AWSCognitoAuthPlugin+Configure.swift 65.73% <0.00%> (-8.33%) ⬇️
...Configuration/AmplifyAWSServiceConfiguration.swift 41.66% <ø> (ø)
...tpClientEngine/ClientRuntimeFoundationBridge.swift 0.00% <0.00%> (ø)
...ustomHttpClientEngine/FoundationClientEngine.swift 0.00% <0.00%> (ø)
...HttpClientEngine/FoundationClientEngineError.swift 0.00% <0.00%> (ø)
...atchLoggingPlugin/AWSCloudWatchLoggingPlugin.swift 33.76% <0.00%> (ø)
...in/Service/Predictions/AWSPredictionsService.swift 11.62% <0.00%> (-6.23%) ⬇️
...gePlugin/Service/Storage/AWSS3StorageService.swift 39.22% <43.75%> (+0.67%) ⬆️
...tionGeoPlugin/AWSLocationGeoPlugin+Configure.swift 100.00% <100.00%> (ø)
...Plugin/AWSCloudWatchLoggingSessionController.swift 41.66% <100.00%> (+3.07%) ⬆️

... and 14 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@phantumcode phantumcode temporarily deployed to Fortify September 15, 2023 19:55 — with GitHub Actions Inactive
@ruisebas ruisebas temporarily deployed to IntegrationTest September 19, 2023 20:30 — with GitHub Actions Inactive
@ruisebas ruisebas temporarily deployed to IntegrationTest September 19, 2023 20:33 — with GitHub Actions Inactive
@ruisebas ruisebas temporarily deployed to IntegrationTest September 19, 2023 20:33 — with GitHub Actions Inactive
@ruisebas ruisebas temporarily deployed to IntegrationTest September 19, 2023 20:33 — with GitHub Actions Inactive
@ruisebas ruisebas temporarily deployed to IntegrationTest September 19, 2023 20:33 — with GitHub Actions Inactive
@ruisebas ruisebas temporarily deployed to IntegrationTest September 19, 2023 20:33 — with GitHub Actions Inactive
@ruisebas ruisebas temporarily deployed to IntegrationTest September 19, 2023 20:33 — with GitHub Actions Inactive
@ruisebas ruisebas temporarily deployed to IntegrationTest September 19, 2023 20:33 — with GitHub Actions Inactive
@ruisebas ruisebas temporarily deployed to IntegrationTest September 19, 2023 20:33 — with GitHub Actions Inactive
@ruisebas ruisebas temporarily deployed to IntegrationTest September 19, 2023 20:33 — with GitHub Actions Inactive
@ruisebas ruisebas temporarily deployed to IntegrationTest September 19, 2023 20:33 — with GitHub Actions Inactive
@ruisebas ruisebas temporarily deployed to IntegrationTest September 19, 2023 20:33 — with GitHub Actions Inactive
@phantumcode phantumcode temporarily deployed to Fortify September 21, 2023 17:36 — with GitHub Actions Inactive
@phantumcode phantumcode temporarily deployed to IntegrationTest September 21, 2023 17:36 — with GitHub Actions Inactive
@phantumcode phantumcode temporarily deployed to IntegrationTest September 21, 2023 17:36 — with GitHub Actions Inactive
@phantumcode phantumcode temporarily deployed to IntegrationTest September 21, 2023 18:13 — with GitHub Actions Inactive
* main:
  fix(core): add Foundation HTTP client for watchOS / tvOS (#3230)
  chore: finalize release 2.18.0 [skip ci]
  chore: release 2.18.0 [skip ci]
  feat: Setting mininum watchOS version to 9 (#3229)
  change swift-tools-version to 5.7 (#3193)
  chore: finalize release 2.17.2 [skip ci]
  chore: release 2.17.2 [skip ci]
  fix(datastore): use unwrapped storageEngine to perform datastore operations (#3204)
  fix(datastore): using URLProtocol monitor auth request headers (#3221)
  ci: add dependency review workflow (#3132)
  fix(api): change request interceptors applying logic (#3190)
@phantumcode phantumcode temporarily deployed to Fortify September 21, 2023 18:46 — with GitHub Actions Inactive
@phantumcode phantumcode temporarily deployed to IntegrationTest September 21, 2023 18:46 — with GitHub Actions Inactive
@phantumcode phantumcode temporarily deployed to Fortify September 21, 2023 20:01 — with GitHub Actions Inactive
@phantumcode phantumcode temporarily deployed to IntegrationTest September 21, 2023 20:01 — with GitHub Actions Inactive
@phantumcode phantumcode temporarily deployed to IntegrationTest September 21, 2023 20:02 — with GitHub Actions Inactive
@phantumcode phantumcode temporarily deployed to IntegrationTest September 21, 2023 20:02 — with GitHub Actions Inactive
@phantumcode phantumcode temporarily deployed to IntegrationTest September 21, 2023 20:02 — with GitHub Actions Inactive
@phantumcode phantumcode temporarily deployed to Fortify September 21, 2023 20:42 — with GitHub Actions Inactive
@phantumcode phantumcode merged commit 0a37e4a into main Sep 26, 2023
76 checks passed
@phantumcode phantumcode deleted the test/log_integration branch September 26, 2023 17:39
phantumcode added a commit that referenced this pull request Sep 26, 2023
* main:
  chore(ci): update dependency review config file path (#3233)
  test(logging): add logging plugin integration test (#3218)
  chore: remove unnecessary CloudWatch dependency from logger plugin (#3235)
  chore: Update CHANGELOG.md for 2.18.0 (#3236)
  chore: finalize release 2.18.1 [skip ci]
  chore: release 2.18.1 [skip ci]
  fix(datastore): call errorHandler in Sync operation when failure
phantumcode added a commit that referenced this pull request Sep 26, 2023
* main:
  chore(ci): update dependency review config file path (#3233)
  test(logging): add logging plugin integration test (#3218)
  chore: remove unnecessary CloudWatch dependency from logger plugin (#3235)
  chore: Update CHANGELOG.md for 2.18.0 (#3236)
  chore: finalize release 2.18.1 [skip ci]
  chore: release 2.18.1 [skip ci]
  fix(core): add Foundation HTTP client for watchOS / tvOS (#3230)
  chore: finalize release 2.18.0 [skip ci]
  chore: release 2.18.0 [skip ci]
  fix(datastore): call errorHandler in Sync operation when failure
  feat: Setting mininum watchOS version to 9 (#3229)
  change swift-tools-version to 5.7 (#3193)
  chore: finalize release 2.17.2 [skip ci]
  chore: release 2.17.2 [skip ci]
  fix(datastore): use unwrapped storageEngine to perform datastore operations (#3204)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants