Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(datastore): use unwrapped storageEngine to perform datastore operations #3204

Merged
merged 2 commits into from
Sep 15, 2023
Merged

fix(datastore): use unwrapped storageEngine to perform datastore operations #3204

merged 2 commits into from
Sep 15, 2023

Conversation

5d
Copy link
Member

@5d 5d commented Sep 1, 2023 •
edited
Loading

Issue #

#3198

Description

Made datastore local operations (save, query, delete) using the instance of initStorageEngine result.

General Checklist

  • Added new tests to cover change, if needed
  • Build succeeds with all target using Swift Package Manager
  • All unit tests pass
  • All integration tests pass
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Documentation update for the change if required
  • PR title conforms to conventional commit style
  • New or updated tests include Given When Then inline code documentation and are named accordingly testThing_condition_expectation()
  • If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@5d 5d temporarily deployed to Fortify September 5, 2023 20:23 — with GitHub Actions Inactive
@5d 5d temporarily deployed to Fortify September 5, 2023 20:40 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest September 5, 2023 21:00 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest September 5, 2023 21:00 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest September 5, 2023 21:00 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest September 5, 2023 21:00 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest September 5, 2023 21:00 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest September 5, 2023 21:00 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest September 5, 2023 21:00 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest September 5, 2023 21:00 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest September 5, 2023 21:00 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest September 5, 2023 21:00 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest September 5, 2023 21:00 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest September 5, 2023 21:00 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest September 5, 2023 21:00 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest September 5, 2023 21:00 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest September 5, 2023 22:37 — with GitHub Actions Inactive
@5d 5d marked this pull request as ready for review September 5, 2023 23:01
@5d 5d requested a review from a team as a code owner September 5, 2023 23:01
@5d 5d temporarily deployed to IntegrationTest September 6, 2023 21:51 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest September 6, 2023 21:51 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest September 6, 2023 21:51 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest September 6, 2023 21:51 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest September 6, 2023 21:51 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest September 6, 2023 21:51 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest September 6, 2023 21:51 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest September 6, 2023 21:51 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest September 6, 2023 21:51 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest September 6, 2023 21:51 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest September 6, 2023 21:51 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest September 6, 2023 21:51 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest September 6, 2023 21:51 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest September 6, 2023 21:51 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest September 6, 2023 21:51 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest September 6, 2023 21:51 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest September 6, 2023 21:51 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest September 6, 2023 21:51 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest September 6, 2023 21:51 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest September 6, 2023 21:51 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest September 6, 2023 21:51 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest September 6, 2023 21:51 — with GitHub Actions Inactive
@5d 5d merged commit 9a05bdd into main Sep 15, 2023
98 checks passed
@5d 5d deleted the 5d/issue-3198 branch September 15, 2023 16:33
phantumcode added a commit that referenced this pull request Sep 21, 2023
@phantumcode
Merge branch 'main' into test/log_integration
a4ef536 
* main:
  fix(core): add Foundation HTTP client for watchOS / tvOS (#3230)
  chore: finalize release 2.18.0 [skip ci]
  chore: release 2.18.0 [skip ci]
  feat: Setting mininum watchOS version to 9 (#3229)
  change swift-tools-version to 5.7 (#3193)
  chore: finalize release 2.17.2 [skip ci]
  chore: release 2.17.2 [skip ci]
  fix(datastore): use unwrapped storageEngine to perform datastore operations (#3204)
  fix(datastore): using URLProtocol monitor auth request headers (#3221)
  ci: add dependency review workflow (#3132)
  fix(api): change request interceptors applying logic (#3190)
phantumcode added a commit that referenced this pull request Sep 26, 2023
@phantumcode
Merge branch 'main' into phantum/geo_unit_tests
59d7bfd 
* main:
  chore(ci): update dependency review config file path (#3233)
  test(logging): add logging plugin integration test (#3218)
  chore: remove unnecessary CloudWatch dependency from logger plugin (#3235)
  chore: Update CHANGELOG.md for 2.18.0 (#3236)
  chore: finalize release 2.18.1 [skip ci]
  chore: release 2.18.1 [skip ci]
  fix(core): add Foundation HTTP client for watchOS / tvOS (#3230)
  chore: finalize release 2.18.0 [skip ci]
  chore: release 2.18.0 [skip ci]
  fix(datastore): call errorHandler in Sync operation when failure
  feat: Setting mininum watchOS version to 9 (#3229)
  change swift-tools-version to 5.7 (#3193)
  chore: finalize release 2.17.2 [skip ci]
  chore: release 2.17.2 [skip ci]
  fix(datastore): use unwrapped storageEngine to perform datastore operations (#3204)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lawmicha lawmicha lawmicha approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@5d @codecov-commenter @lawmicha