Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: change swift-tools-version to 5.7 #3193

Merged
merged 1 commit into from
Sep 19, 2023
Merged

Conversation

atierian
Copy link
Member

@atierian atierian commented Aug 30, 2023

Description

Bump to Swift 5.7

Documentation changes already merged:

General Checklist

  • Added new tests to cover change, if needed
  • Build succeeds with all target using Swift Package Manager
  • All unit tests pass
  • All integration tests pass
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Documentation update for the change if required
  • PR title conforms to conventional commit style
  • New or updated tests include Given When Then inline code documentation and are named accordingly testThing_condition_expectation()
  • If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@atierian atierian requested a review from a team as a code owner August 30, 2023 17:11
@atierian atierian marked this pull request as draft August 30, 2023 17:20
@codecov-commenter
Copy link

codecov-commenter commented Aug 30, 2023

Codecov Report

Merging #3193 (fa9114d) into main (8bbf5c7) will increase coverage by 0.01%.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main    #3193      +/-   ##
==========================================
+ Coverage   64.74%   64.75%   +0.01%     
==========================================
  Files        1090     1090              
  Lines       36997    36997              
==========================================
+ Hits        23953    23958       +5     
+ Misses      13044    13039       -5     
Flag Coverage Δ
API_plugin_unit_test 66.52% <ø> (ø)
AWSPluginsCore 69.55% <ø> (ø)
Amplify 47.86% <ø> (+0.01%) ⬆️
Analytics_plugin_unit_test 86.39% <ø> (ø)
Auth_plugin_unit_test 75.21% <ø> (+0.02%) ⬆️
CoreMLPredictions_plugin_unit_test 59.44% <ø> (ø)
DataStore_plugin_unit_test 81.11% <ø> (+0.01%) ⬆️
Geo_plugin_unit_test 54.06% <ø> (ø)
Logging_plugin_unit_test 62.61% <ø> (ø)
Predictions_plugin_unit_test 35.17% <ø> (ø)
PushNotifications_plugin_unit_test 69.43% <ø> (ø)
Storage_plugin_unit_test 54.10% <ø> (ø)
unit_tests 64.75% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 9 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@atierian atierian force-pushed the swift-five-dot-seven branch from 437a2c9 to fa9114d Compare August 30, 2023 17:33
@atierian atierian temporarily deployed to Fortify August 30, 2023 17:33 — with GitHub Actions Inactive
@atierian atierian marked this pull request as ready for review August 30, 2023 19:04
@atierian atierian merged commit f1b6fa1 into main Sep 19, 2023
5 checks passed
@atierian atierian deleted the swift-five-dot-seven branch September 19, 2023 20:10
phantumcode added a commit that referenced this pull request Sep 21, 2023
* main:
  fix(core): add Foundation HTTP client for watchOS / tvOS (#3230)
  chore: finalize release 2.18.0 [skip ci]
  chore: release 2.18.0 [skip ci]
  feat: Setting mininum watchOS version to 9 (#3229)
  change swift-tools-version to 5.7 (#3193)
  chore: finalize release 2.17.2 [skip ci]
  chore: release 2.17.2 [skip ci]
  fix(datastore): use unwrapped storageEngine to perform datastore operations (#3204)
  fix(datastore): using URLProtocol monitor auth request headers (#3221)
  ci: add dependency review workflow (#3132)
  fix(api): change request interceptors applying logic (#3190)
phantumcode added a commit that referenced this pull request Sep 26, 2023
* main:
  chore(ci): update dependency review config file path (#3233)
  test(logging): add logging plugin integration test (#3218)
  chore: remove unnecessary CloudWatch dependency from logger plugin (#3235)
  chore: Update CHANGELOG.md for 2.18.0 (#3236)
  chore: finalize release 2.18.1 [skip ci]
  chore: release 2.18.1 [skip ci]
  fix(core): add Foundation HTTP client for watchOS / tvOS (#3230)
  chore: finalize release 2.18.0 [skip ci]
  chore: release 2.18.0 [skip ci]
  fix(datastore): call errorHandler in Sync operation when failure
  feat: Setting mininum watchOS version to 9 (#3229)
  change swift-tools-version to 5.7 (#3193)
  chore: finalize release 2.17.2 [skip ci]
  chore: release 2.17.2 [skip ci]
  fix(datastore): use unwrapped storageEngine to perform datastore operations (#3204)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants