Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(storage) Parity: AWS SDK S3 accelerate via useAccelerateEndpoint pluginOptions. #3087

Merged
merged 1 commit into from
Jul 17, 2023

Conversation

harsh62
Copy link
Member

@harsh62 harsh62 commented Jul 13, 2023

Originally opened by @jcjimenez in #2631 ... Taking up the work from there to finish it.

Issues

#2591
#1542

Description of changes

This change makes it possible to leverage the existing AWS SDK S3 configuration in the same way that it is done for Javascript/React. #featureparity

Check points: (check or cross out if not relevant)

  • Added new tests to cover change, if needed
  • Build succeeds with all target using Swift Package Manager
  • All unit tests pass
  • All integration tests pass
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Documentation update for the change if required
  • PR title conforms to conventional commit style
  • If breaking change, documentation/changelog update with migration instructions

Testing Procedure Followed

  1. Ensure the S3 bucket used by Amplify has Transfer Acceleration disabled.
    Screenshot_2022-12-21_at_11_06_40_AM
  2. Ensure all integration tests pass.
  3. Enable transfer acceleration locally by updating the tests under AWSS3StoragePluginAccelerateIntegrationTests setting useAccelerateEndpoint to true.
  4. Run the integration tests. They should all fail.
  5. Enable Transfer Acceleration using the AWS Console.
    Screenshot_2022-12-21_at_11_06_55_AM
  6. Ensure the integration tests now pass.
    Screenshot_2022-12-21_at_11_12_06_AM
  7. Disable transfer acceleration locally by updating the tests under AWSS3StoragePluginAccelerateIntegrationTests setting useAccelerateEndpoint to false.
  8. Ensure the integration tests pass, even though the client is no longer using the accelerate feature and the S3 bucket still has it enabled.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@harsh62 harsh62 force-pushed the feat/storage-acceleration-hsinghvq branch from 3522927 to d797c89 Compare July 13, 2023 20:25
@harsh62 harsh62 temporarily deployed to IntegrationTest July 13, 2023 20:40 — with GitHub Actions Inactive
@harsh62 harsh62 temporarily deployed to IntegrationTest July 13, 2023 20:40 — with GitHub Actions Inactive
@harsh62 harsh62 temporarily deployed to IntegrationTest July 13, 2023 21:59 — with GitHub Actions Inactive
@harsh62 harsh62 temporarily deployed to IntegrationTest July 13, 2023 21:59 — with GitHub Actions Inactive
@harsh62 harsh62 temporarily deployed to IntegrationTest July 14, 2023 02:48 — with GitHub Actions Inactive
@harsh62 harsh62 temporarily deployed to IntegrationTest July 14, 2023 02:48 — with GitHub Actions Inactive
@harsh62 harsh62 temporarily deployed to IntegrationTest July 14, 2023 02:48 — with GitHub Actions Inactive
@harsh62 harsh62 marked this pull request as ready for review July 14, 2023 03:09
@harsh62 harsh62 requested a review from a team as a code owner July 14, 2023 03:09
@harsh62
Copy link
Member Author

harsh62 commented Jul 14, 2023

@harsh62 harsh62 merged commit 54e1100 into main Jul 17, 2023
@harsh62 harsh62 deleted the feat/storage-acceleration-hsinghvq branch July 17, 2023 20:23
harsh62 added a commit that referenced this pull request Jul 18, 2023
harsh62 added a commit that referenced this pull request Jul 18, 2023
@harsh62 harsh62 restored the feat/storage-acceleration-hsinghvq branch July 20, 2023 15:45
@harsh62 harsh62 deleted the feat/storage-acceleration-hsinghvq branch July 21, 2023 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants