Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Storage) Use default URLSession configuration for non-multipart uploads #1542 #2594

Closed
wants to merge 1 commit into from

Conversation

jcjimenez
Copy link
Contributor

Issue #, if available:
#1542

Description of changes:
This change maintains the use of the background URLSessionConfiguration + URLSession for upload operations that result in multi-part uploads and download operations but switches to a default URLSessionConfiguration for upload operations of smaller files that result in non-multipart uploads.

Check points: (check or cross out if not relevant)

  • [x ] Added new tests to cover change, if needed
  • Build succeeds with all target using Swift Package Manager
  • All unit tests pass
  • All integration tests pass
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Documentation update for the change if required
  • PR title conforms to conventional commit style
  • If breaking change, documentation/changelog update with migration instructions

DataStore checkpoints (check when completed)

  • Ran AWSDataStorePluginIntegrationTests
  • Ran AWSDataStorePluginV2Tests
  • Ran AWSDataStorePluginMultiAuthTests
  • Ran AWSDataStorePluginCPKTests
  • Ran AWSDataStorePluginAuthCognitoTests
  • Ran AWSDataStorePluginAuthIAMTests

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jcjimenez jcjimenez requested a review from a team as a code owner November 28, 2022 15:03
@jcjimenez jcjimenez requested review from 5d and atierian November 28, 2022 15:04
@jcjimenez jcjimenez self-assigned this Nov 28, 2022
@jcjimenez jcjimenez closed this Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant