-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(datastore): filter authrules with invalid ownerfield #1606
Conversation
Can't wait for this to be merged. Any ETA? Cheers. |
Same over here! |
Hi @diegocstn. I know you have loads on your plate, but I have 2 projects waiting for this PR to go through and released. Can we expedite it, seems like we are 99% of the way? Cheers. |
@diegocstn, while we wait for this PR to go through, is there a temporary workaround? E.g. can the primary owner be turned into an array, so we can at least support multi-owner? type PostDraftCognitoMultiOwner @model
@auth(rules: [
{ allow: owner }
]) {
id: ID!
title: String!
content: String
owner: [String]
}
|
@diegocstn, can you provide an update for this issue? It's been almost 3months, and yet this need-to-have feature is still not working on iOS. |
Almost 4months has passed and a standard feature in amplify-cli is still not supported in a major SDK. Unfortunately this will kill all my iOS related projects going forward. |
any further with this? |
Documentation was updated recently with something that could indicate there is support for this feature. Could there be light at the end of the tunnel? |
This PR is no longer needed, it was re-done in #3223 |
Description of changes:
This PR introduces changes to
AuthRuleDecorator
to support multiple rules with different owner fields as per documentation.Given the following schema
AppSync generates
Check points: (check or cross out if not relevant)
- [ ] Build succeeds with all target using Swift Package Manager- [ ] Documentation update for the change if required- [ ] If breaking change, documentation/changelog update with migration instructionsBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.