Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release(required): Amplify JS release #14072

Merged
merged 14 commits into from
Dec 12, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 21 additions & 21 deletions .github/CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
Expand Up @@ -15,24 +15,24 @@

# The following paths involve server-side use cases, token/user session management.
# Changes made to these paths requires additional reviews and approvals.
/packages/auth @haverchuck @cshfang @HuiSF @pranavosu
/packages/aws-amplify/src/adapter-core @haverchuck @cshfang @HuiSF @pranavosu
/packages/core/src/adapterCore @haverchuck @cshfang @HuiSF @pranavosu
/packages/core/src/singleton @haverchuck @cshfang @HuiSF @pranavosu
/packages/core/src/utils/convert @haverchuck @cshfang @HuiSF @pranavosu
/packages/core/src/utils/WordArray.ts @haverchuck @cshfang @HuiSF @pranavosu
/packages/core/src/storage @haverchuck @cshfang @HuiSF @pranavosu
/packages/core/src/utils/generateRandomString.ts @haverchuck @cshfang @HuiSF @pranavosu
/packages/core/src/utils/globalHelpers @haverchuck @cshfang @HuiSF @pranavosu
/packages/core/src/utils/urlSafeDecode.ts @haverchuck @cshfang @HuiSF @pranavosu
/packages/core/src/awsClients/cognitoIdentity @haverchuck @cshfang @HuiSF @pranavosu
/packages/core/src/clients/internal @haverchuck @cshfang @HuiSF @pranavosu
/packages/core/src/Hub @haverchuck @cshfang @HuiSF @pranavosu
/packages/adapter-nextjs @haverchuck @cshfang @HuiSF @pranavosu
/packages/rtn-web-browser @haverchuck @cshfang @HuiSF @pranavosu
/packages/storage/src/providers/s3/apis/internal @haverchuck @cshfang @HuiSF @pranavosu
/packages/storage/src/providers/s3/apis/server @haverchuck @cshfang @HuiSF @pranavosu
/packages/api-rest/src/apis/server.ts @haverchuck @cshfang @HuiSF @pranavosu
/packages/api-rest/src/apis/common/internalPost.ts @haverchuck @cshfang @HuiSF @pranavosu
/packages/api-graphql/src/server @haverchuck @cshfang @HuiSF @pranavosu
/packages/api-graphql/src/internals/server @haverchuck @cshfang @HuiSF @pranavosu
/packages/auth @sktimalsina @cshfang @HuiSF @pranavosu
/packages/aws-amplify/src/adapter-core @sktimalsina @cshfang @HuiSF @pranavosu
/packages/core/src/adapterCore @sktimalsina @cshfang @HuiSF @pranavosu
/packages/core/src/singleton @sktimalsina @cshfang @HuiSF @pranavosu
/packages/core/src/utils/convert @sktimalsina @cshfang @HuiSF @pranavosu
/packages/core/src/utils/WordArray.ts @sktimalsina @cshfang @HuiSF @pranavosu
/packages/core/src/storage @sktimalsina @cshfang @HuiSF @pranavosu
/packages/core/src/utils/generateRandomString.ts @sktimalsina @cshfang @HuiSF @pranavosu
/packages/core/src/utils/globalHelpers @sktimalsina @cshfang @HuiSF @pranavosu
/packages/core/src/utils/urlSafeDecode.ts @sktimalsina @cshfang @HuiSF @pranavosu
/packages/core/src/awsClients/cognitoIdentity @sktimalsina @cshfang @HuiSF @pranavosu
/packages/core/src/clients/internal @sktimalsina @cshfang @HuiSF @pranavosu
/packages/core/src/Hub @sktimalsina @cshfang @HuiSF @pranavosu
/packages/adapter-nextjs @sktimalsina @cshfang @HuiSF @pranavosu
/packages/rtn-web-browser @sktimalsina @cshfang @HuiSF @pranavosu
/packages/storage/src/providers/s3/apis/internal @sktimalsina @cshfang @HuiSF @pranavosu
/packages/storage/src/providers/s3/apis/server @sktimalsina @cshfang @HuiSF @pranavosu
/packages/api-rest/src/apis/server.ts @sktimalsina @cshfang @HuiSF @pranavosu
/packages/api-rest/src/apis/common/internalPost.ts @sktimalsina @cshfang @HuiSF @pranavosu
/packages/api-graphql/src/server @sktimalsina @cshfang @HuiSF @pranavosu
/packages/api-graphql/src/internals/server @sktimalsina @cshfang @HuiSF @pranavosu
47 changes: 26 additions & 21 deletions .github/integ-config/integ-all.yml
Original file line number Diff line number Diff line change
Expand Up @@ -875,22 +875,32 @@ tests:
# spec: duplicate-packages
# browser: *minimal_browser_list

# SSR context isolation
- test_name: integ_ssr_context_isolation
desc: 'SSR Context Isolation'
# Next.js use cases
- test_name: integ_next-use-cases-14
desc: 'Next.js use cases tests with v14'
framework: next
category: ssr-adapter
sample_name: ssr-context-isolation
spec: ssr-context-isolation
yarn_script: ci:ssr-context-isolation
sample_name: next-use-cases-14
spec: next-use-cases
yarn_script: ci:next-use-cases-test
yarn_script_args: 14
browser: [chrome]
- test_name: integ_next-use-cases-15
desc: 'Next.js use cases tests with v15'
framework: next
category: ssr-adapter
sample_name: next-use-cases-15
spec: next-use-cases
yarn_script: ci:next-use-cases-test
yarn_script_args: 15
browser: [chrome]
- test_name: integ_next_mfa_req_email
desc: 'mfa required with email sign in attribute'
framework: next
category: auth
sample_name: [mfa]
spec: mfa-req-email
browser: [chrome]
browser: *minimal_browser_list
env:
NEXT_PUBLIC_BACKEND_CONFIG: mfa-req-email
- test_name: integ_next_mfa_req_phone
Expand All @@ -899,7 +909,7 @@ tests:
category: auth
sample_name: [mfa]
spec: mfa-req-phone
browser: [chrome]
browser: *minimal_browser_list
env:
NEXT_PUBLIC_BACKEND_CONFIG: mfa-req-phone
- test_name: integ_next_mfa_opt_email
Expand All @@ -908,7 +918,7 @@ tests:
category: auth
sample_name: [mfa]
spec: mfa-opt-email
browser: [chrome]
browser: *minimal_browser_list
env:
NEXT_PUBLIC_BACKEND_CONFIG: mfa-opt-email
- test_name: integ_next_mfa_opt_phone
Expand All @@ -917,7 +927,7 @@ tests:
category: auth
sample_name: [mfa]
spec: mfa-opt-phone
browser: [chrome]
browser: *minimal_browser_list
env:
NEXT_PUBLIC_BACKEND_CONFIG: mfa-opt-phone
- test_name: integ_next_mfa_setup
Expand All @@ -926,7 +936,7 @@ tests:
category: auth
sample_name: [mfa]
spec: mfa-setup
browser: [chrome]
browser: *minimal_browser_list
env:
NEXT_PUBLIC_BACKEND_CONFIG: mfa-setup
- test_name: integ_next_passwordless_auto_sign_in
Expand All @@ -935,8 +945,7 @@ tests:
category: auth
sample_name: [mfa]
spec: passwordless/auto-sign-in
# browser: *minimal_browser_list
browser: [chrome]
browser: *minimal_browser_list
env:
NEXT_PUBLIC_BACKEND_CONFIG: pwl-autosignin
- test_name: integ_next_passwordless_first_factor_selection
Expand All @@ -945,8 +954,7 @@ tests:
category: auth
sample_name: [mfa]
spec: passwordless/first-factor-selection
# browser: *minimal_browser_list
browser: [chrome]
browser: *minimal_browser_list
env:
NEXT_PUBLIC_BACKEND_CONFIG: pwl-ffselect
- test_name: integ_next_passwordless_preferred_challenge
Expand All @@ -955,8 +963,7 @@ tests:
category: auth
sample_name: [mfa]
spec: passwordless/preferred-challenge
# browser: *minimal_browser_list
browser: [chrome]
browser: *minimal_browser_list
env:
NEXT_PUBLIC_BACKEND_CONFIG: pwl-prefchal
- test_name: integ_next_passwordless_sign_up
Expand All @@ -965,8 +972,7 @@ tests:
category: auth
sample_name: [mfa]
spec: passwordless/sign-up
# browser: *minimal_browser_list
browser: [chrome]
browser: *minimal_browser_list
env:
NEXT_PUBLIC_BACKEND_CONFIG: pwl-signup
- test_name: integ_next_passwordless_misc
Expand All @@ -975,8 +981,7 @@ tests:
category: auth
sample_name: [mfa]
spec: passwordless/miscellaneous
# browser: *minimal_browser_list
browser: [chrome]
browser: *minimal_browser_list
env:
NEXT_PUBLIC_BACKEND_CONFIG: pwl-misc
- test_name: integ_next_passwordless_webauthn
Expand Down
6 changes: 5 additions & 1 deletion .github/workflows/callable-e2e-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,9 @@ on:
yarn_script:
required: false
type: string
yarn_script_args:
required: false
type: number
env:
required: false
type: string
Expand Down Expand Up @@ -124,6 +127,7 @@ jobs:
E2E_RETRY_COUNT: ${{ inputs.retry_count }}
E2E_TEST_NAME: ${{ inputs.test_name }}
E2E_YARN_SCRIPT: ${{ inputs.yarn_script }}
E2E_YARN_SCRIPT_ARGS: ${{ inputs.yarn_script_args }}
E2E_ENV: ${{ inputs.env }}
run: |
if [ -z "$E2E_YARN_SCRIPT" ]; then
Expand All @@ -141,7 +145,7 @@ jobs:
$E2E_YARN_SCRIPT \
-n $E2E_RETRY_COUNT
else
yarn "$E2E_YARN_SCRIPT"
yarn "$E2E_YARN_SCRIPT" "$E2E_YARN_SCRIPT_ARGS"
fi
- name: Upload artifact
uses: actions/upload-artifact@0b7f8abb1508181956e8e162db84b466c27e18ce # v3.1.2 https://github.com/actions/upload-artifact/commit/0b7f8abb1508181956e8e162db84b466c27e18ce
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/callable-e2e-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ jobs:
timeout_minutes: ${{ matrix.integ-config.timeout_minutes || 35 }}
retry_count: ${{ matrix.integ-config.retry_count || 3 }}
yarn_script: ${{ matrix.integ-config.yarn_script || '' }}
yarn_script_args: ${{ matrix.integ-config.yarn_script_args || 15 }}
env: ${{ matrix.integ-config.env && toJSON(matrix.integ-config.env) || '{}' }}

# e2e-test-runner-headless:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ describe('createServerRunner', () => {
});

describe('when nextServerContext is not null', () => {
it('should create auth providers with cookie storage adapter', () => {
it('should create auth providers with cookie storage adapter', async () => {
const operation = jest.fn();
const mockCookieStorageAdapter = {
get: jest.fn(),
Expand All @@ -147,7 +147,7 @@ describe('createServerRunner', () => {
const { runWithAmplifyServerContext } = createServerRunner({
config: mockAmplifyConfig,
});
runWithAmplifyServerContext({
await runWithAmplifyServerContext({
operation,
nextServerContext:
mockNextServerContext as unknown as NextServer.Context,
Expand Down
Loading
Loading