chore: fix canary failure with incompatible NPM #12082
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The attempt to run new sample app test in Node.js 18 and 20 failed because OpenSSL incompatibility: https://github.com/aws-amplify/amplify-js/actions/runs/6242039120/job/16945255084?pr=12082 |
jimblanc
reviewed
Sep 20, 2023
Comment on lines
+4
to
+7
| pull_request: | ||
| branches: [fix-canary-engine-failure] | ||
| push: | ||
| branches: [fix-canary-engine-failure] |
There was a problem hiding this comment.
Need to switch this back before merging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Remove the repetative npm@latest installation that causes the failure. The NPM installation already happend other tasks:
amplify-js/.github/workflows/callable-canary-sampleapp-tests.yml
Line 32 in dd3dea1
Issue #, if available
Example failure: https://github.com/aws-amplify/amplify-js/actions/runs/6238043024/job/16934343712
Description of how you validated changes
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.