Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Upgrading to latest version of MapLibre iOS #31

Merged
merged 5 commits into from
Aug 14, 2024

Conversation

ruisebas
Copy link
Member

Issue #, if available:

Description of changes:
This PR does the following:

  • Addresses the compilation error caused due to some AWS SDK for Swift renaming
  • Upgrades to the latest MapLibre Native version, which moved away from OpenGL and now uses Metal
    • This solves crashes on startup that are seen when building with Xcode 15
    • Several internal renames were needed to accommodate this, mainly the MGL -> MLN prefix
  • Removes the "NSExpression is forbidden" warning by tweaking the creation of said expressions
  • Fixes an empty map being displayed due to a wrong formatting in the URL path inside our URLProtocol.
  • Updates the build_test workflow to use a newer device and checkout action.

Check points: (check or cross out if not relevant)

  • Ran swiftformat (from repository root): swiftformat Sources Tests
  • Ran swiftlint (from repository root): swiftlint Sources Tests and addressed all violations.
  • Added new tests to cover change, if needed
  • Build succeeds with all targets using Swift Package Manager
  • All unit tests pass
  • All integration tests pass
  • Documentation update for the change if required
  • PR title conforms to conventional commit style
  • If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ruisebas ruisebas requested a review from a team as a code owner May 14, 2024 18:55
@ruisebas ruisebas force-pushed the ruisebas/upgrade-maplibre branch from 5660bd9 to cc51ead Compare August 14, 2024 17:55
@ruisebas ruisebas merged commit 78fcf54 into main Aug 14, 2024
2 checks passed
@ruisebas ruisebas deleted the ruisebas/upgrade-maplibre branch August 14, 2024 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants