-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(storage): add multi-bucket feature support #5681
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NikaHsn
force-pushed
the
multi-bucket
branch
from
November 20, 2024 17:12
c606a3d
to
9e63b54
Compare
Equartey
previously approved these changes
Nov 20, 2024
tyllark
previously approved these changes
Nov 20, 2024
blakedunson
reviewed
Nov 25, 2024
"buckets": [ | ||
{ | ||
"name": "amplifyTeamDrive-one", | ||
"bucket_name": "amplifyTeamDrive-one-stora-testbucketgen2bucket0b8c-9ggcfqfunkjr", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will ping @NikaHsn internally
blakedunson
approved these changes
Nov 26, 2024
Equartey
previously approved these changes
Nov 26, 2024
tyllark
previously approved these changes
Nov 26, 2024
…t for multi-bucket support (#5493)
* added bucket option to list api options and added tests * updated tests to account for changes to uploadData api --------- Co-authored-by: ekjotmultani <[email protected]> Co-authored-by: NikaHsn <[email protected]> Co-authored-by: Tyler-Larkin <[email protected]> Co-authored-by: Elijah Quartey <[email protected]>
* Updated dowload file options to accept bucket parameter added integration tests * updated todo message * updates variable names and tests * Update packages/storage/amplify_storage_s3_dart/lib/src/amplify_storage_s3_dart_impl.dart --------- Co-authored-by: NikaHsn <[email protected]>
* chore(core): Added toJson to storage option buckets * feat(storage): multi bucket copy
tyllark
approved these changes
Dec 4, 2024
ekjotmultani
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.