Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(storage): add multi-bucket feature support #5681

Merged
merged 25 commits into from
Dec 9, 2024
Merged

feat(storage): add multi-bucket feature support #5681

merged 25 commits into from
Dec 9, 2024

Conversation

NikaHsn
Copy link
Member

@NikaHsn NikaHsn commented Nov 20, 2024

Issue #, if available:

Description of changes:

  • update Amplify Storage APIs to accept optional bucket parameter to support multi-bucket feature

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@NikaHsn NikaHsn requested a review from a team as a code owner November 20, 2024 00:00
Equartey
Equartey previously approved these changes Nov 20, 2024
tyllark
tyllark previously approved these changes Nov 20, 2024
"buckets": [
{
"name": "amplifyTeamDrive-one",
"bucket_name": "amplifyTeamDrive-one-stora-testbucketgen2bucket0b8c-9ggcfqfunkjr",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will ping @NikaHsn internally

@NikaHsn NikaHsn dismissed stale reviews from tyllark and Equartey via dd38767 November 26, 2024 19:30
Equartey
Equartey previously approved these changes Nov 26, 2024
tyllark
tyllark previously approved these changes Nov 26, 2024
NikaHsn and others added 20 commits December 3, 2024 14:28
* added bucket option to list api options and added tests

* updated tests to account for changes to uploadData api

---------

Co-authored-by: ekjotmultani <[email protected]>
Co-authored-by: NikaHsn <[email protected]>
Co-authored-by: Tyler-Larkin <[email protected]>
Co-authored-by: Elijah Quartey <[email protected]>
Equartey and others added 5 commits December 3, 2024 14:28
* Updated dowload file options to accept bucket parameter
added integration tests

* updated todo message

* updates variable names and tests

* Update packages/storage/amplify_storage_s3_dart/lib/src/amplify_storage_s3_dart_impl.dart

---------

Co-authored-by: NikaHsn <[email protected]>
* chore(core): Added toJson to storage option buckets

* feat(storage): multi bucket copy
@NikaHsn NikaHsn dismissed stale reviews from tyllark and Equartey via 4622de3 December 3, 2024 22:32
@NikaHsn NikaHsn merged commit 5b7b82e into main Dec 9, 2024
155 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants