Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(storage): multi bucket get url #5659

Merged
merged 1 commit into from
Nov 11, 2024
Merged

Conversation

Equartey
Copy link
Contributor

@Equartey Equartey commented Nov 8, 2024

Description of changes:

  • Updated getUrl api to accept an optional bucket parameter
  • Added Unit tests
  • Corrected previous multi bucket tests that were placed in the wrong group.
  • Added E2E test

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@Equartey Equartey requested a review from a team as a code owner November 8, 2024 20:27
@Equartey Equartey merged commit ce73ca0 into multi-bucket Nov 11, 2024
155 checks passed
@Equartey Equartey deleted the feat/multi-bucket-get-url branch November 11, 2024 19:51
NikaHsn pushed a commit that referenced this pull request Nov 20, 2024
NikaHsn pushed a commit that referenced this pull request Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants