feat(storage): multi bucket download data #5599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| path: StoragePath.fromIdentityId( | ||
| (identityId) => 'private/$identityId/$identityName', | ||
| ), | ||
| options: StorageDownloadDataOptions(bucket: mainBucket), |
There was a problem hiding this comment.
Q: should this be tested on the secondary bucket instead? otherwise this test targets the same bucket as the previous ones since they default to the main bucket with no bucket specified
There was a problem hiding this comment.
Good question, let me include a to-do to add the secondary bucket after upload file/data is merged. Right now there's no way to upload to the secondary bucket.
ekjotmultani
approved these changes
Oct 24, 2024
tyllark
approved these changes
Oct 28, 2024
ekjotmultani
pushed a commit
that referenced
this pull request
Nov 4, 2024
NikaHsn
pushed a commit
that referenced
this pull request
Nov 20, 2024
NikaHsn
pushed a commit
that referenced
this pull request
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
StorageDownloadDataOptionsto have a optional bucket param to specify target for operationBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.