feat(storage): multi bucket list api #5576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lify/amplify-flutter into storage-output-update
…y/amplify-flutter into storage-output-update
feat(core): update storage outputs class for multi-bucket support
Multi bucket infra update
…t for multi-bucket support (#5493)
merging changes from main that unblock some tests
ekjotmultani
changed the title
Equartey
reviewed
Oct 21, 2024
packages/storage/amplify_storage_s3/example/integration_test/list_test.dart
Outdated
Show resolved
Hide resolved
NikaHsn
force-pushed
the
multi-bucket
branch
2 times, most recently
from
3eafd51 to
a2d5efb
Compare
Equartey
reviewed
Oct 25, 2024
Comment on lines
36
to
57
| for (var pathIndex = 0; | ||
| pathIndex < uploadedPaths.length ~/ 2; | ||
| pathIndex++) { | ||
| await Amplify.Storage.uploadData( | ||
| path: StoragePath.fromString(path), | ||
| path: StoragePath.fromString(uploadedPaths[pathIndex]), | ||
| data: StorageDataPayload.bytes('test content'.codeUnits), | ||
| bucket: mainBucket, | ||
| ).result; | ||
| } | ||
| for (var pathIndex = uploadedPaths.length ~/ 2; | ||
| pathIndex < uploadedPaths.length; | ||
| pathIndex++) { | ||
| await Amplify.Storage.uploadData( | ||
| path: StoragePath.fromString(uploadedPaths[pathIndex]), | ||
| data: StorageDataPayload.bytes('test content'.codeUnits), | ||
| bucket: secondaryBucket, | ||
| ).result; | ||
| } |
There was a problem hiding this comment.
Q: why break up the uploads?
There was a problem hiding this comment.
they are uploading to different buckets, I can put them in the same loop but I think two calls to upload will be required
Equartey
approved these changes
Oct 28, 2024
NikaHsn
approved these changes
Oct 31, 2024
…5567) * fix(api): Reconnect WebSocket when resuming app from a paused state
chore(version): Bump version ### Features - feat(api): move App Sync subscription headers to protocol ([#5301](#5301)) - feat(authenticator): export unmet password requirements ([#5437](#5437)) ### Fixes - fix(api): Reconnect WebSocket when resuming app from a paused state ([#5567](#5567)) Updated-Components: amplify_lints, Amplify Flutter, Amplify Dart, Amplify UI, DB Common, Secure Storage, AWS Common, Smithy, Worker Bee
ekjotmultani
force-pushed
the
feat/multi-bucket-list-api
branch
from
885cc98 to
309fca4
Compare
NikaHsn
added a commit
that referenced
this pull request
Nov 20, 2024
* added bucket option to list api options and added tests * updated tests to account for changes to uploadData api --------- Co-authored-by: ekjotmultani <[email protected]> Co-authored-by: NikaHsn <[email protected]> Co-authored-by: Tyler-Larkin <[email protected]> Co-authored-by: Elijah Quartey <[email protected]>
NikaHsn
added a commit
that referenced
this pull request
Dec 3, 2024
* added bucket option to list api options and added tests * updated tests to account for changes to uploadData api --------- Co-authored-by: ekjotmultani <[email protected]> Co-authored-by: NikaHsn <[email protected]> Co-authored-by: Tyler-Larkin <[email protected]> Co-authored-by: Elijah Quartey <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
added storage bucket option to the options type for the list api
added integration tests
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.