Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated: feat(storage): implementation for delimiter support to list API #5112

Closed
wants to merge 52 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
52 commits
Select commit Hold shift + click to select a range
b809dad
feat: refine subpathstrat class impl
hahnandrew Jul 3, 2024
8735de1
feat: naive impl for subpath strategy class
hahnandrew Jul 5, 2024
b0f6e10
fix: deleting subpath strat class in core
hahnandrew Jul 5, 2024
482847c
chore(storage): add todo comment about macros
hahnandrew Jul 5, 2024
b9252fb
feat (storage): add subpathstrategy to storagelistoptions
hahnandrew Jul 8, 2024
a71461b
chore(storage): add @deprecated decorators to S3ListPluginOptions
hahnandrew Jul 8, 2024
e4b565c
feat(storage): implementation for delimiter change
hahnandrew Jul 8, 2024
8ee42d7
feat(storage): add subpath field in StorageListOptions
hahnandrew Jul 8, 2024
65df9a9
chore(storage): clarifying subpath class description
hahnandrew Jul 8, 2024
cfa6637
chore(storage): example app
hahnandrew Jul 8, 2024
f098111
chore(storage): change storage list api implementation
hahnandrew Jul 8, 2024
3426d3b
chore: removed % of decorators in list plugin options
hahnandrew Jul 8, 2024
4d86f26
chore(storage): adding TODO's for post delim list changes
hahnandrew Jul 8, 2024
f472248
chore(storage): changing test suite to reflect delim changes
hahnandrew Jul 8, 2024
6dcfbe7
feat(storage): adding list api delim changes to storage s3 impl
hahnandrew Jul 8, 2024
1396f62
chore(storage): changed unit test to reflect storage delim list changes
hahnandrew Jul 8, 2024
1c43961
Merge pull request #5129 from aws-amplify/feat/delimiter-unit-test
hahnandrew Jul 8, 2024
ce89fbf
chore(storage): reflect integration test for changed s3 list delim
hahnandrew Jul 8, 2024
977236b
chore(storage): change internal s3metadata and add deprecated decorators
hahnandrew Jul 8, 2024
973dcab
chore(storage): adding unit test changes for s3 list delim
hahnandrew Jul 8, 2024
6329aa8
Merge branch 'feat/delimiter-unit-test' into feat/delimiter-impl
hahnandrew Jul 8, 2024
b27ed79
chore(storage): handling delim deprecation gracefully
hahnandrew Jul 8, 2024
932e47c
chore(storage): handling delim deprecation more gracefully in s3metadata
hahnandrew Jul 8, 2024
68ae89e
chore(storage): adding additional decorators for s3listpluginoptions …
hahnandrew Jul 8, 2024
3210bf6
chore(storage): change constructor call to reflect delim changes
hahnandrew Jul 8, 2024
e58826e
fix(storage): deprecated_member_use fix
hahnandrew Jul 8, 2024
fb0a456
chore(storage): migrating delim deprecation changes
hahnandrew Jul 8, 2024
7ede198
fix(storage): unit test hidden syntax error
hahnandrew Jul 8, 2024
1f47eaf
chore(storage): fixing type cast error in storage_s3_service_test
hahnandrew Jul 8, 2024
1544505
chore(storage): adding deprecation decorators to s3listplugoptions
hahnandrew Jul 8, 2024
ffe0880
chore(storage): mockito mismatch null returns with delim changes
hahnandrew Jul 9, 2024
7a13ca0
chore(storage): updating mockito suites for delim changes
hahnandrew Jul 9, 2024
15aa405
fix(notifications): allow configuration when auth token is expired (#…
NikaHsn Jul 9, 2024
95dff17
test(delim): update mockito unit suites for delim changes
hahnandrew Jul 9, 2024
23a02da
test(delim): update mockito unit suites for delim changes
hahnandrew Jul 9, 2024
7572915
fix: add ignore headers
hahnandrew Jul 10, 2024
9a16bd2
test: removing deprecation subpath in test
hahnandrew Jul 10, 2024
29a3bfc
test: specify incldues method in unit tests
hahnandrew Jul 10, 2024
d564485
fix(datastore): prevent auth plugin from throwing during configuratio…
khatruong2009 Jul 10, 2024
c130d63
chore(actions): xcodes ios 18 fix
Equartey Jul 10, 2024
5bd7e91
add debug message
Equartey Jul 10, 2024
58f1036
remove version
Equartey Jul 10, 2024
7c90d7d
remove version distc
Equartey Jul 10, 2024
7b45bb7
revert debugs. Removed latest flag
Equartey Jul 11, 2024
2ddbef6
update pnpm action
Equartey Jul 11, 2024
2f14446
bump pnpm version
Equartey Jul 11, 2024
4d10354
Merge branch 'chore/ci-ios-simulator' into feat/delimiter-impl
hahnandrew Jul 11, 2024
e17bb17
test(storage): add delimiter to integration tests"
hahnandrew Jul 11, 2024
ea7c32f
test(storage): add deprecation comments
hahnandrew Jul 11, 2024
3a9db55
test: add delimiter parameters to test
hahnandrew Jul 11, 2024
fbb44bb
test: delete example tests
hahnandrew Jul 11, 2024
305c06f
test: fixing formatting
hahnandrew Jul 11, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .flutter-plugins
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
# This is a generated file; do not edit or check into version control.
connectivity_plus=/Users/hahnand/.pub-cache/hosted/pub.dev/connectivity_plus-6.0.3/
device_info_plus=/Users/hahnand/.pub-cache/hosted/pub.dev/device_info_plus-10.1.0/
flutter_plugin_android_lifecycle=/Users/hahnand/.pub-cache/hosted/pub.dev/flutter_plugin_android_lifecycle-2.0.20/
package_info_plus=/Users/hahnand/.pub-cache/hosted/pub.dev/package_info_plus-6.0.0/
1 change: 1 addition & 0 deletions .flutter-plugins-dependencies
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
{"info":"This is a generated file; do not edit or check into version control.","plugins":{"ios":[{"name":"connectivity_plus","path":"/Users/hahnand/.pub-cache/hosted/pub.dev/connectivity_plus-6.0.3/","shared_darwin_source":true,"native_build":true,"dependencies":[]},{"name":"device_info_plus","path":"/Users/hahnand/.pub-cache/hosted/pub.dev/device_info_plus-10.1.0/","native_build":true,"dependencies":[]},{"name":"package_info_plus","path":"/Users/hahnand/.pub-cache/hosted/pub.dev/package_info_plus-6.0.0/","native_build":true,"dependencies":[]}],"android":[{"name":"connectivity_plus","path":"/Users/hahnand/.pub-cache/hosted/pub.dev/connectivity_plus-6.0.3/","native_build":true,"dependencies":[]},{"name":"device_info_plus","path":"/Users/hahnand/.pub-cache/hosted/pub.dev/device_info_plus-10.1.0/","native_build":true,"dependencies":[]},{"name":"flutter_plugin_android_lifecycle","path":"/Users/hahnand/.pub-cache/hosted/pub.dev/flutter_plugin_android_lifecycle-2.0.20/","native_build":true,"dependencies":[]},{"name":"package_info_plus","path":"/Users/hahnand/.pub-cache/hosted/pub.dev/package_info_plus-6.0.0/","native_build":true,"dependencies":[]}],"macos":[{"name":"connectivity_plus","path":"/Users/hahnand/.pub-cache/hosted/pub.dev/connectivity_plus-6.0.3/","shared_darwin_source":true,"native_build":true,"dependencies":[]},{"name":"device_info_plus","path":"/Users/hahnand/.pub-cache/hosted/pub.dev/device_info_plus-10.1.0/","native_build":true,"dependencies":[]},{"name":"package_info_plus","path":"/Users/hahnand/.pub-cache/hosted/pub.dev/package_info_plus-6.0.0/","native_build":true,"dependencies":[]}],"linux":[{"name":"connectivity_plus","path":"/Users/hahnand/.pub-cache/hosted/pub.dev/connectivity_plus-6.0.3/","native_build":false,"dependencies":[]},{"name":"device_info_plus","path":"/Users/hahnand/.pub-cache/hosted/pub.dev/device_info_plus-10.1.0/","native_build":false,"dependencies":[]},{"name":"package_info_plus","path":"/Users/hahnand/.pub-cache/hosted/pub.dev/package_info_plus-6.0.0/","native_build":false,"dependencies":[]}],"windows":[{"name":"connectivity_plus","path":"/Users/hahnand/.pub-cache/hosted/pub.dev/connectivity_plus-6.0.3/","native_build":true,"dependencies":[]},{"name":"device_info_plus","path":"/Users/hahnand/.pub-cache/hosted/pub.dev/device_info_plus-10.1.0/","native_build":false,"dependencies":[]},{"name":"package_info_plus","path":"/Users/hahnand/.pub-cache/hosted/pub.dev/package_info_plus-6.0.0/","native_build":false,"dependencies":[]}],"web":[{"name":"connectivity_plus","path":"/Users/hahnand/.pub-cache/hosted/pub.dev/connectivity_plus-6.0.3/","dependencies":[]},{"name":"device_info_plus","path":"/Users/hahnand/.pub-cache/hosted/pub.dev/device_info_plus-10.1.0/","dependencies":[]},{"name":"package_info_plus","path":"/Users/hahnand/.pub-cache/hosted/pub.dev/package_info_plus-6.0.0/","dependencies":[]}]},"dependencyGraph":[{"name":"connectivity_plus","dependencies":[]},{"name":"device_info_plus","dependencies":[]},{"name":"flutter_plugin_android_lifecycle","dependencies":[]},{"name":"package_info_plus","dependencies":[]}],"date_created":"2024-06-24 20:21:39.026901","version":"3.22.1"}

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion .github/composite_actions/launch_ios_simulator/action.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ description: Launches an iOS simulator and caches it for further action runs
inputs:
ios-version:
description: The iOS version
default: "latest"
default: "17.5"
runs:
using: "node16"
main: "dist/index.mjs"
34 changes: 17 additions & 17 deletions .github/composite_actions/launch_ios_simulator/dist/main.cjs

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Large diffs are not rendered by default.

Loading
Loading